Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3489670pxf; Mon, 29 Mar 2021 03:48:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzR5HG1AfrIkggTwRr5wNzlVVTzMmuSAuNieSvxYVuFWJN47+JmZrWghGPw7Yj9XQlwXkoY X-Received: by 2002:a17:906:85b:: with SMTP id f27mr28254066ejd.414.1617014927058; Mon, 29 Mar 2021 03:48:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617014927; cv=none; d=google.com; s=arc-20160816; b=uSPFUcmrwqkV3gKUixZD2lBf5JzXXlZ3rn5ONh+W7gJ0S0Vl9UQ+rdAiZMsP9WczJO P+J5iMJxRskAyj/QWwe+ikZ/wXaDxt4iB0/XC49/isJoeUCNCoRsdw/p2cl94wFKqVjs GsiBk5VcdnNeD4qID7xS8k2KVR16D7ZWlgL7mVSol272oil5ojJfBPW2oltwS9mzoOcb uX0AjoyC7u3qRxP0RskDDK3hZeZ4YJYW50lHBoylCiC7rjNfYbDQFf2rJH6PIWbojdUB kXUljxJFHxz1i36O5usqceB7b2gAu/MP8vCCtBXyZOVpib82ZfTpVrjr+1RYUJgqGil/ jZQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gtf6o2mxdjje1osIG01wi+DpHqggBbpCUrGm5kv2rVY=; b=EetMB2xJyWlZuZwshsz9kptZHD2UgL/cnBAawv3OntWg120ZbRg04C7O4pUV+PsW48 EGtDZAmF/WSyvwHxwg2DKdiQNtO/PKJviq9pRDoDuFNNaMJO4svjwrZJ7lCg1u0zJt3J 9RKiaN1NTgbinUheYP9spdumnWfc/NSbCOdKq4iFDvwURHNGTS4cedIqO6Fds8YlF1Y9 UJqLzI2JqWJaRDXqjxch4+ve3Xv6DpObS0ZUf/+Ut/DQ0f0AhRWfTlOYelzCghRxRRVi 9K6STOfIU5iXdyjzo2vezU7evVRu+ueJcBaQKUkQj4e3L6kCAamtANcYgsOQny3nN2Og xauw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aUFgZIwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u10si8024980ejg.204.2021.03.29.03.48.24; Mon, 29 Mar 2021 03:48:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aUFgZIwB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234846AbhC2Ih1 (ORCPT + 99 others); Mon, 29 Mar 2021 04:37:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:39388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234014AbhC2IWv (ORCPT ); Mon, 29 Mar 2021 04:22:51 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 41F0761481; Mon, 29 Mar 2021 08:22:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1617006170; bh=4TpIWM0Iw3OCYVJdAt9Issv49bFdkaG9NC/gB3Ax5Go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aUFgZIwBZhaSjk7LiX5xVWSwobuynMLH0kC2EGoSy5HutI1JsFhKM2nfvJma5hGPU AF9KhS9x2ErpKRN7F1IJ7QGhrz8o29D78AQMMCxvBH4i7xTIVH3Q7fAYmYpPXFxlxx UPMNfozbe23KcwKn1E5IgR0F79FEG5Fjh0zsq1y4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Muhammad Husaini Zulkifli , Malli C , Dvora Fuxbrumer , Sasha Neftin , Tony Nguyen , Sasha Levin Subject: [PATCH 5.10 107/221] igc: Fix Supported Pause Frame Link Setting Date: Mon, 29 Mar 2021 09:57:18 +0200 Message-Id: <20210329075632.783504760@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210329075629.172032742@linuxfoundation.org> References: <20210329075629.172032742@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Muhammad Husaini Zulkifli [ Upstream commit 9a4a1cdc5ab52118c1f2b216f4240830b6528d32 ] The Supported Pause Frame always display "No" even though the Advertised pause frame showing the correct setting based on the pause parameters via ethtool. Set bit in link_ksettings to "Supported" for Pause Frame. Before output: Supported pause frame use: No Expected output: Supported pause frame use: Symmetric Fixes: 8c5ad0dae93c ("igc: Add ethtool support") Signed-off-by: Muhammad Husaini Zulkifli Reviewed-by: Malli C Tested-by: Dvora Fuxbrumer Acked-by: Sasha Neftin Signed-off-by: Tony Nguyen Signed-off-by: Sasha Levin --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c index 35c104a02bed..da259cd59add 100644 --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c @@ -1695,6 +1695,9 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev, Autoneg); } + /* Set pause flow control settings */ + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause); + switch (hw->fc.requested_mode) { case igc_fc_full: ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause); -- 2.30.1