Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210328180124.8762-1-dmugil2000@gmail.com> <CAHp75Vdv4zAsn_v1TaUcYgY_PpQrfhfGNsc8=QTbPY=oFN_xbA@mail.gmail.com>
In-Reply-To: <CAHp75Vdv4zAsn_v1TaUcYgY_PpQrfhfGNsc8=QTbPY=oFN_xbA@mail.gmail.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 29 Mar 2021 13:52:35 +0300
Message-ID: <CAHp75VdS=Px4MdhA5mzzqaQEsMs3ur76m+tYb1inVqBFfu_CRA@mail.gmail.com>
Subject: Re: [PATCH] iio: accel: da280: Drop unnecessarily used braces
To:     Mugilraj Dhavachelvan <dmugil2000@gmail.com>,
        Hans de Goede <hdegoede@redhat.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        Hartmut Knaack <knaack.h@gmx.de>,
        Lars-Peter Clausen <lars@metafoo.de>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

+Cc: Hans (just for your opinion)

On Sun, Mar 28, 2021 at 10:40 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sunday, March 28, 2021, Mugilraj Dhavachelvan <dmugil2000@gmail.com> w=
rote:
>>
>> As per linux kernel coding style braces are not needed for single
>> statement.
>> Checkpatch
>> warning: braces {} are not necessary for any arm of this statement
>> 128: FILE: drivers/iio/accel/da280.c:128:
>>
>
> While it=E2=80=99s the correct patch, I would rather recommend making the=
 driver non-ACPI centric. I.e.:
> - replace that custom function by device_get_match_data() call
>
> - replace that condition by something like
> type =3D device_get_match_data();
>
> - drop ACPI_PTR()
>
> - replace acpi.h by mod_devicetable.h and property.h
>
> - convert to use ->probe_new()
>
>
>  Everything, except the last one is in one patch, the last one is another=
 patch.
>
>
>
>> Signed-off-by: Mugilraj Dhavachelvan <dmugil2000@gmail.com>
>> ---
>>  drivers/iio/accel/da280.c | 5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/iio/accel/da280.c b/drivers/iio/accel/da280.c
>> index 227bea2d738b..31f290ae4386 100644
>> --- a/drivers/iio/accel/da280.c
>> +++ b/drivers/iio/accel/da280.c
>> @@ -125,11 +125,10 @@ static int da280_probe(struct i2c_client *client,
>>         indio_dev->modes =3D INDIO_DIRECT_MODE;
>>         indio_dev->channels =3D da280_channels;
>>
>> -       if (ACPI_HANDLE(&client->dev)) {
>> +       if (ACPI_HANDLE(&client->dev))
>>                 chip =3D da280_match_acpi_device(&client->dev);
>> -       } else {
>> +       else
>>                 chip =3D id->driver_data;
>> -       }
>>
>>         if (chip =3D=3D da226) {
>>                 indio_dev->name =3D "da226";

--=20
With Best Regards,
Andy Shevchenko