Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 29 Mar 2021 13:26:29 +0200
Message-ID: <s5hy2e6i4ka.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     root <wang.yi59@zte.com.cn>
Cc:     perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
        wang.liang82@zte.com.cn, Jia Zhou <zhou.jia2@zte.com.cn>
Subject: Re: [PATCH] ALSA: core: remove redundant spin_lock pair in snd_card_disconnect
In-Reply-To: <1616989007-34429-1-git-send-email-wang.yi59@zte.com.cn>
References: <1616989007-34429-1-git-send-email-wang.yi59@zte.com.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 29 Mar 2021 05:36:47 +0200,
root wrote:
> 
> [1.1.1  <text/plain; UTF-8 (base64)>]
> 
> From: Jia Zhou <zhou.jia2@zte.com.cn>
> 
> modification in commit 2a3f7221acdd ("ALSA: core: Fix card races between
> register and disconnect") resulting in this problem.
> 
> Signed-off-by: Jia Zhou <zhou.jia2@zte.com.cn>
> Signed-off-by: Yi Wang <wang.yi59@zte.com.cn>

The code change looks good, but the patch isn't cleanly applicable via
git-am.  Could you fix your MUA setup, or try to submit via
git-send-email?


thanks,

Takashi

> ---
>  sound/core/init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/core/init.c b/sound/core/init.c
> index 018ce4ef1..9f5270c90 100644
> --- a/sound/core/init.c
> +++ b/sound/core/init.c
> @@ -390,10 +390,8 @@ int snd_card_disconnect(struct snd_card *card)
>          return 0;
>      }
>      card->shutdown = 1;
> -    spin_unlock(&card->files_lock);
>  
>      /* replace file->f_op with special dummy operations */
> -    spin_lock(&card->files_lock);
>      list_for_each_entry(mfile, &card->files_list, list) {
>          /* it's critical part, use endless loop */
>          /* we have no room to fail */
> -- 
> 2.18.4
> 
>