Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next 2/2] s390/cio: use DECLARE_WAIT_QUEUE_HEAD() for
 wait_queue
To:     Shixin Liu <liushixin2@huawei.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210329094019.67044-1-liushixin2@huawei.com>
 <20210329094019.67044-2-liushixin2@huawei.com>
From:   Vineeth Vijayan <vneethv@linux.ibm.com>
Message-ID: <c8abb27b-2b4c-3484-8859-8b4482a4aa1c@linux.ibm.com>
Date:   Mon, 29 Mar 2021 14:34:29 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210329094019.67044-2-liushixin2@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

For both the patches,

Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>

I will correct the description, and Heiko/Vasily will pick this up and 
will be part of the s390-tree patchset.

On 3/29/21 11:40 AM, Shixin Liu wrote:
> wait_queue_head_t can be initialized automatically with DECLARE_WAIT_QUEUE_HEAD()
> rather than explicitly calling init_waitqueue_head().

A minor checkpatch WARNING. I will modify this.

>
> Signed-off-by: Shixin Liu <liushixin2@huawei.com>
> ---
>   drivers/s390/cio/css.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/s390/cio/css.c b/drivers/s390/cio/css.c
> index f01ef6325039..a974943c27da 100644
> --- a/drivers/s390/cio/css.c
> +++ b/drivers/s390/cio/css.c
> @@ -652,13 +652,12 @@ static void css_sch_todo(struct work_struct *work)
>   
>   static struct idset *slow_subchannel_set;
>   static DEFINE_SPINLOCK(slow_subchannel_lock);
> -static wait_queue_head_t css_eval_wq;
> +static DECLARE_WAIT_QUEUE_HEAD(css_eval_wq);
>   static atomic_t css_eval_scheduled;
>   
>   static int __init slow_subchannel_init(void)
>   {
>   	atomic_set(&css_eval_scheduled, 0);
> -	init_waitqueue_head(&css_eval_wq);
>   	slow_subchannel_set = idset_sch_new();
>   	if (!slow_subchannel_set) {
>   		CIO_MSG_EVENT(0, "could not allocate slow subchannel set\n");