Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3566930pxf; Mon, 29 Mar 2021 05:58:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwXvbZTRpTGZT/OGam9fdL42KunNINZpv/2MHseQbHemZkMkpFb/qfZNlPpHQa1Vzmwzs47 X-Received: by 2002:a17:906:ae96:: with SMTP id md22mr27173892ejb.409.1617022684320; Mon, 29 Mar 2021 05:58:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617022684; cv=none; d=google.com; s=arc-20160816; b=vNqHIbALRKSjImLu4/si+doM5lxTWC+RZoh05mYi+AazywRsztRJB2bTk6MR7yrBh+ CPEDWWnhhrZVN7SJ33+O/OhMXG+2VBwYmbGw0cjUT4MYVVYApCDp3QHURtZolF8EsKRD VzXII1xk8VCWT2Qbq8T8TnM939Kcsg7GqIzeXF0tBWz1Rs1gJB3wLRFND2e9T1evTD54 +20QRJBgSt4AM/HGqJIWooLZTdcxZCIivff/nIsBmVs6tnGrBgS2x2nKTjAaHIvCLpJL 54GNcv0nb/UBofYMoJq7lUOIQZXiEUnGOF5HflHUvLFOY7At2J7JfN3ar4tpkwl2aIuB KRyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=InwCmxYMSdSK30tPIOIjxwg8+5+xBZih5Je7WVfDo4M=; b=nXaVp7FGY1tvdQpaN3zN46wXFUgytxLMp0BVmdTD5OfKaKpWKwg3XsCAkV8Zc0u3yS m2aOLGa07TsXozxcuV7z+AEy0IdarhuR8HfKNwdAaP837cUnEDmsZdxCrUkuUA+mPVto 24/TPiKyYDgQrOhjJzY/fFgw33JDf5778L+8GCdxkprIrpVw1rEBc9ffz0WLqmJc7onb eR1NSBwlAeB4o4RMP9/pIWHcvyKWv4lQw8lZwsZyyiBTrOlMORBcgK+ouEFKarmXImXI qQXEpMtFFnT0IJ9Mhht4CwXh94F71X767l4KEXbGfxOPL7UF65LCqStyWClzOlhXTEqD 3lug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="DQIvO4y/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id da5si9232938edb.565.2021.03.29.05.57.41; Mon, 29 Mar 2021 05:58:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="DQIvO4y/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231676AbhC2Mz0 (ORCPT + 99 others); Mon, 29 Mar 2021 08:55:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:47192 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231267AbhC2My4 (ORCPT ); Mon, 29 Mar 2021 08:54:56 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 411E2614A5; Mon, 29 Mar 2021 12:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617022495; bh=gD8OAL8ZgrZxmhmfXI5U0FkI+CeYRCz8TgCwsSh8ha0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DQIvO4y/SdhfupNIesMRydJjNf02VMTjYdEQVa5Vmz0fAuzU2QZWHfmCPBCFkHqB6 OHocQmKEPGCOKUAvcNoyL2owm0o3O4UYX4zbkIVC1O54ZvGVfVRzSTfbhSreOwJ1P5 xBbSmmn/RUV0Iz7Bm5pEmdmy8twaTwZAfmMqdh31wbOwy3hwYS1ogL4FrH6j0Pupci UmJ8ggu1V1fnHg/sjHYn8LXC79uzEevjsmeQ/SjEYg8a3wn9VpJDegL/QQHkYcKzue vZ/IxUmJjFVrRe6T2QizkS/CEhbB+4E0NSIr+VXCjNN274kIlkTNlCQrLKrsNtOX7T WQqiMsrOf40zw== Date: Mon, 29 Mar 2021 13:54:49 +0100 From: Will Deacon To: Lecopzer Chen Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, catalin.marinas@arm.com, ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com, dvyukov@google.com, akpm@linux-foundation.org, tyhicks@linux.microsoft.com, maz@kernel.org, rppt@kernel.org, linux@roeck-us.net, gustavoars@kernel.org, yj.chiang@mediatek.com Subject: Re: [PATCH v4 5/5] arm64: Kconfig: select KASAN_VMALLOC if KANSAN_GENERIC is enabled Message-ID: <20210329125449.GA3805@willie-the-truck> References: <20210324040522.15548-1-lecopzer.chen@mediatek.com> <20210324040522.15548-6-lecopzer.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210324040522.15548-6-lecopzer.chen@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 24, 2021 at 12:05:22PM +0800, Lecopzer Chen wrote: > Before this patch, someone who wants to use VMAP_STACK when > KASAN_GENERIC enabled must explicitly select KASAN_VMALLOC. > > From Will's suggestion [1]: > > I would _really_ like to move to VMAP stack unconditionally, and > > that would effectively force KASAN_VMALLOC to be set if KASAN is in use > > Because VMAP_STACK now depends on either HW_TAGS or KASAN_VMALLOC if > KASAN enabled, in order to make VMAP_STACK selected unconditionally, > we bind KANSAN_GENERIC and KASAN_VMALLOC together. > > Note that SW_TAGS supports neither VMAP_STACK nor KASAN_VMALLOC now, > so this is the first step to make VMAP_STACK selected unconditionally. Do you know if anybody is working on this? It's really unfortunate that we can't move exclusively to VMAP_STACK just because of SW_TAGS KASAN. That said, what is there to do? As things stand, won't kernel stack addresses end up using KASAN_TAG_KERNEL? Will