Subject: Re: [PATCH 06/10] -mm: clocksource: add block notifier
From: john stultz <johnstul@us.ibm.com>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
In-Reply-To: <20061006185456.995993000@mvista.com>
References: <20061006185439.667702000@mvista.com>
	 <20061006185456.995993000@mvista.com>
Content-Type: text/plain
Date: Mon, 09 Oct 2006 12:45:12 -0700
Message-Id: <1160423113.5458.66.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 928
Lines: 28

On Fri, 2006-10-06 at 11:54 -0700, Daniel Walker wrote:
> plain text document attachment
> (clocksource_add_block_notify_on_new_clock.patch)
> Adds a call back interface for register/rating change
> events.
> 
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>

This one looks interesting, but I'm not sure if we yet have the use-case
really needed to implement notifier infrastructure (taking the comments
from my last discussion). I don't really have any criticism with the
code, I just worry it might be over-doing it.

Maybe it would be more persuasive if it went together with the first
users of it, rather then as a independent infrastructure buildup patch.

thanks
-john


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/