Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: YVscrSSmhap16pLG+zKabDcKBTygoNDypzHLJTM+KwJjzcFJ8dnhG1ik+488GbdOXQ/alQkDvK
 LKlVM+M4zhkQ==
IronPort-SDR: 4eVELRd9pZsPnZNimTuGuxMOd9iNPeuOxgA4FtQTcj7L3pfqpUVHF2LA55K8olLS3KTzG9awJ8
 lLSCJwsi/2BA==
Date:   Mon, 29 Mar 2021 18:24:36 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Syed Nayyar Waris <syednwaris@gmail.com>
Cc:     bgolaszewski@baylibre.com, vilhelm.gray@gmail.com,
        michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com,
        linus.walleij@linaro.org, yamada.masahiro@socionext.com,
        akpm@linux-foundation.org, rui.zhang@intel.com,
        daniel.lezcano@linaro.org, amit.kucheria@verdurent.com,
        linux-arch@vger.kernel.org, linux-gpio@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value
 and _set_value
Message-ID: <YGHxNFXAjcg4PfnE@smile.fi.intel.com>
References: <cover.1615038553.git.syednwaris@gmail.com>
 <4c259d34b5943bf384fd3cb0d98eccf798a34f0f.1615038553.git.syednwaris@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4c259d34b5943bf384fd3cb0d98eccf798a34f0f.1615038553.git.syednwaris@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Sat, Mar 06, 2021 at 07:36:30PM +0530, Syed Nayyar Waris wrote:
> This patch reimplements the xgpio_set_multiple() function in
> drivers/gpio/gpio-xilinx.c to use the new generic functions:
> bitmap_get_value() and bitmap_set_value(). The code is now simpler
> to read and understand. Moreover, instead of looping for each bit
> in xgpio_set_multiple() function, now we can check each channel at
> a time and save cycles.

...

> +	u32 *const state = chip->gpio_state;

Looking at this... What's the point of the const here?

Am I right that this tells: pointer is a const, while the data underneath
can be modified?

> +	unsigned int *const width = chip->gpio_width;

Ditto.

Putting const:s here and there for sake of the const is not good practice.
It makes code harder to read.

-- 
With Best Regards,
Andy Shevchenko