Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3724665pxf; Mon, 29 Mar 2021 09:40:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxQNdWk8QLkjBS1ZA6bfiwdPzqVVG74klnzdzlvRB2hmZPpoyt8abEydbeNLGZ0y81qVRij X-Received: by 2002:aa7:d687:: with SMTP id d7mr28784706edr.118.1617036020266; Mon, 29 Mar 2021 09:40:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617036020; cv=none; d=google.com; s=arc-20160816; b=aJWTny15RVGYCA06P/S+vWA0r/ITnOWdfoZTX4abxKYNABklYvyx+AxpmMMP0kr3sE upqV6V4bTuGLou6u4YCjYRfLMA/VurbnWOE122dRG4WZYQY1LJtJ6j6J8MNfpHrfzjHU FjzmBLasbaIZM1XDVhdTze7/SWFSP3vhaX5SGQ1kEuoWj8aJiyFUfOXrL/PIVCvLKKGd z4j7/D4Uh0Dha+to4RMJhQKcNgnvG2GwfV7Z8XQmdprA/9fbdKaMDf23P6Fo1/69FcO2 RE70i5HYydxHycJLOdpWHoStEgmixFQe0zy+m+u+Ot4Hknm4W2ezhM2IJUz6N5ITxOVT +N3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MTmpotKO9nQgIN5ZjXhj4X36rPku8Dx7D0Tu3VxJP8E=; b=H3BQHGjwjuQMxynilyGBMD7Vnv7ErI/yFbuSj3nt8EBYYfWw2Zp8hKSExVSJ50RBJT 80NewzEtpkGVBCCa/pIBbbU5T7ioIFwL3lkwX/UJu5ncTXquHNoxNfPFCGtLXD6CfsYU 6G9csVOp6kOSRiLaIMa94LeKiQ/YelNiY0mdeNhEsDapg5MCfD+juaav8vx4byGYsSHd W9iiW0/YYDEoQwseTFW7C+wpts9aHCLu6V2Vw7wYDOif9fEhYzkQFb1lmpjfTsoKS55z HnJBgkhbxiRn5gvcNPxbofhaBhz2Rkdb4wK8WWiIbgmMqm4h0HNxOEyhEKBm9dqJVLHk bt/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ahSYwZ35; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fi16si13398927ejb.239.2021.03.29.09.39.57; Mon, 29 Mar 2021 09:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ahSYwZ35; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230052AbhC2QjA (ORCPT + 99 others); Mon, 29 Mar 2021 12:39:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:51060 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229515AbhC2Qij (ORCPT ); Mon, 29 Mar 2021 12:38:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617035918; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MTmpotKO9nQgIN5ZjXhj4X36rPku8Dx7D0Tu3VxJP8E=; b=ahSYwZ3599qPJSUq/Gf4GBqKD+gY8w7Kw7khn4sYEDsnS12sPYDl5TX8OWcvUATfTfe/BZ nj4HRV4MFtd8jQPqNCuyRiDmdvKx4g7ioKOfimUOwQNMc74DMg7ij9TsyD2E211xoKuq8v UkO/CMAWfxZSlff0zbPFVJSkOGQJTUA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-281-g7Oo5IVlOKuZbqTu5AvQsA-1; Mon, 29 Mar 2021 12:38:34 -0400 X-MC-Unique: g7Oo5IVlOKuZbqTu5AvQsA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 965F41927800; Mon, 29 Mar 2021 16:38:32 +0000 (UTC) Received: from treble (ovpn-120-130.rdu2.redhat.com [10.10.120.130]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1EF685D6A8; Mon, 29 Mar 2021 16:38:30 +0000 (UTC) Date: Mon, 29 Mar 2021 11:38:26 -0500 From: Josh Poimboeuf To: Peter Zijlstra Cc: x86@kernel.org, jgross@suse.com, mbenes@suse.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 16/16] objtool,x86: Rewrite retpoline thunk calls Message-ID: <20210329163826.anuqkv5ahvoyus5c@treble> References: <20210326151159.128534163@infradead.org> <20210326151300.320177914@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210326151300.320177914@infradead.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 26, 2021 at 04:12:15PM +0100, Peter Zijlstra wrote: > @@ -61,3 +89,15 @@ SYM_FUNC_END(__x86_indirect_thunk_\reg) > #define GEN(reg) EXPORT_THUNK(reg) > #include > > +#undef GEN > +#define GEN(reg) ALT_THUNK reg > +#include > + > +#undef GEN > +#define GEN(reg) __EXPORT_THUNK(__x86_indirect_alt_call_ ## reg) > +#include > + > +#undef GEN > +#define GEN(reg) __EXPORT_THUNK(__x86_indirect_alt_jmp_ ## reg) > +#include > + Git complains about this last newline. Otherwise everything looks pretty good to me. Let me run it through the test matrix. -- Josh