Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 29 Mar 2021 13:30:15 -0500
From:   David Teigland <teigland@redhat.com>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     linux-kernel@vger.kernel.org, cluster-devel@redhat.com
Subject: Re: [PATCH -next] fs: dlm: fix missing unlock on error in
 accept_from_sock()
Message-ID: <20210329183015.GE3080@redhat.com>
References: <20210327083704.1092954-1-yangyingliang@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210327083704.1092954-1-yangyingliang@huawei.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Precedence: bulk

On Sat, Mar 27, 2021 at 04:37:04PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from accept_from_sock()
> in the error handling case.

Thanks, applied to the next branch.
Dave

> Fixes: 6cde210a9758 ("fs: dlm: add helper for init connection")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  fs/dlm/lowcomms.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c
> index 73cc1809050a..166e36fcf3e4 100644
> --- a/fs/dlm/lowcomms.c
> +++ b/fs/dlm/lowcomms.c
> @@ -931,6 +931,7 @@ static int accept_from_sock(struct listen_connection *con)
>  			result = dlm_con_init(othercon, nodeid);
>  			if (result < 0) {
>  				kfree(othercon);
> +				mutex_unlock(&newcon->sock_mutex);
>  				goto accept_err;
>  			}
>  
> -- 
> 2.25.1