Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3875527pxf; Mon, 29 Mar 2021 14:07:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzF5ON0qK7KZZ0pZ/3cZxy/vyOCV6RHVNktY3VnI7gjrt2Sbw381d34hxe5BC9f7/5a6777 X-Received: by 2002:aa7:d987:: with SMTP id u7mr29884568eds.326.1617052036679; Mon, 29 Mar 2021 14:07:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617052036; cv=none; d=google.com; s=arc-20160816; b=PCjT/olLt/n9m0+kbsEjRwp2A3UMpgjYZUct++sSEAXLlW+bCp7miUhHXBGOMAOKn+ lMmHBOA6xc7Na3SCQ7HrbzLSbDBqAWji+c5uBXuEo4hLCwsZ/1n/sL2yqouyPAq/2JkQ yMUYNxpWjqxmxAthXQbCT5KKbs9cB0tBdx0jnz6qZcLoYBCePiwbhJ4Fm7ulMeyN3j0U Nx29vlD/8FO6DS2pMcv1zeW45TLNFqFtSv7q9RgNFY2WDklylGETW5p49SGYlVQRhOks yo3OhNjygs/6b2PtCmlwcEyheMv4qC5652IMP2hfxCS59YdFYi0/0+0xi+Ki/KLXWbmQ QetQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=BwfrYzDEehksizkTpjK73uBB+vQzg9/8Zhq70VLpg04=; b=ud0K2PqO/w7WGtvKKWDu7T4qtSlGQuc6hE4qT0MSad1XxsorQkCG6HD/JE+EZeCD4O fMswtY+AzM8CKelen56yYD5X0/EiIzwDh705s89gPCi8Hm7UyQi7bfAppuC7Z3K4gqIM dOTniT2VUqwLx6I2IGRiEMpqTxK5FW6yx4EtU8WpERgic/26Vj/sFZBFfyHNh8IH5cXa 0pAUoAXDf+83xLwVM96pMwzOHv4uJxEq91Vfrr4s/kiNybEtI19ducE9NaAQSHQnucmw lN2RNqBfTFIQhJjKKauN9xfqoEKsGSbuqRIVxHlaViVCDgbJJwpJAAEX4YBbTe2rc/Mu O83Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n24si8810793ejr.200.2021.03.29.14.06.53; Mon, 29 Mar 2021 14:07:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230526AbhC2VDy (ORCPT + 99 others); Mon, 29 Mar 2021 17:03:54 -0400 Received: from mga06.intel.com ([134.134.136.31]:48312 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbhC2VDm (ORCPT ); Mon, 29 Mar 2021 17:03:42 -0400 IronPort-SDR: gD/H4/T46Y1fbY+dg76Jv1OfyjmkZOoLL5WNAx9x7CtW77yXQ8KgFWEXxUVVDW/D9kuCm4JI3u wFFsfnpG+rRw== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="252970997" X-IronPort-AV: E=Sophos;i="5.81,288,1610438400"; d="scan'208";a="252970997" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 14:03:42 -0700 IronPort-SDR: lzTsoGTpeGUNutDxGIcoQyA2JBxCXayDDEM4oMNIBef2LKg/nMeuOImLRswPvXJXSnTW2FnP1v JsYRselswgBg== X-IronPort-AV: E=Sophos;i="5.81,288,1610438400"; d="scan'208";a="411273851" Received: from jmwolcot-mobl.amr.corp.intel.com (HELO [10.209.158.84]) ([10.209.158.84]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2021 14:03:41 -0700 Subject: Re: I915 CI-run with kfence enabled, issues found To: Marco Elver Cc: "Sarvela, Tomi P" , "kasan-dev@googlegroups.com" , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , the arch/x86 maintainers , "H. Peter Anvin" , LKML References: <66f453a79f2541d4b05bcd933204f1c9@intel.com> <796ff05e-c137-cbd4-252b-7b114abaced9@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Mon, 29 Mar 2021 14:03:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/29/21 10:45 AM, Marco Elver wrote: > On Mon, 29 Mar 2021 at 19:32, Dave Hansen wrote: > Doing it to all CPUs is too expensive, and we can tolerate this being > approximate (nothing bad will happen, KFENCE might just miss a bug and > that's ok). ... >> BTW, the preempt checks in flush_tlb_one_kernel() are dependent on KPTI >> being enabled. That's probably why you don't see this everywhere. We >> should probably have unconditional preempt checks in there. > > In which case I'll add a preempt_disable/enable() pair to > kfence_protect_page() in arch/x86/include/asm/kfence.h. That sounds sane to me. I'd just plead that the special situation (not needing deterministic TLB flushes) is obvious. We don't want any folks copying this code. BTW, I know you want to avoid the cost of IPIs, but have you considered any other low-cost ways to get quicker TLB flushes? For instance, you could loop over all CPUs and set cpu_tlbstate.invalidate_other=1. That would induce a context switch at the next context switch without needing an IPI.