Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3951330pxf; Mon, 29 Mar 2021 16:34:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwtLyZPN+UkKoDfE5WzICukxqwWVjd3KyZe19uCvWNvO7GXDMDqSJbbewvlURNqOKm8kwUz X-Received: by 2002:aa7:c3c4:: with SMTP id l4mr30507879edr.335.1617060858520; Mon, 29 Mar 2021 16:34:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617060858; cv=none; d=google.com; s=arc-20160816; b=ToayMxhjF7TriWF2HoKTf4EPmiHJKSEbgqa9mwS6EyaUHjQ/iNjtfUUpTnL1F1ownU 9ZeljCN8z3QIfqFBJWR1zaCPvf8LE+TkvIl/I99XNrwmEiCTDbGQeTVNGDs0pxblwq9v VQSEqHTKSOMzcB6MZgvUudPxv732q1Z6Xe4lg/TzaQEM4v8pXY5wYwQEfOuI8diSvsti s5HHGtJ2iQyl2p0PxI/DYdzc6wOTqom46f6s+i/GpsSgCN1xPVawoM0OD8u+STwcv0DQ mHSGvV6R6I0Af1hRKzKKBDWtf3DUGX7CuaeFzGo5tY4loBXXLH5J8mYJg+y7Z17jOFls n2pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=qEr5SKLk9Uj7oMF96+m/e4OCnS2ph+lSz2MaIHUdUwI=; b=x3gWpefI/zMCx0fRJbZaiClmUMRv6eVvrL6mXBZBkgsUZz1LflI5lNtmToXtgoLZHS OROjRL2ZbZ8VONIvADFkr/XMkgDFmaMjuWcehNO8QIX7a4zJ7I243xBN74mtCujOXplF M7lk3p4zFr8IiCUDUAYql3noC8HlNYQJdh7aHUGzXMNTsR7lhZjKSZ+NQAJIti3Ypijj 0BZswD6Niia212oNnyTW5xh4/zteFYzqFPp8YYxFpH05DvfSe/Kil9HhcJO0fxZvgdNX 2JYmdt+VyBJygV2KOeju2NRCl3fHLrxAyBdFTGxSckBQZ/9/26QB5I7wQuRAqDSUXxPs 4b3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ggJZNBiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ho20si14787233ejc.295.2021.03.29.16.33.55; Mon, 29 Mar 2021 16:34:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ggJZNBiq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230432AbhC2XaP (ORCPT + 99 others); Mon, 29 Mar 2021 19:30:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:40032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbhC2XaJ (ORCPT ); Mon, 29 Mar 2021 19:30:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 1167A61990; Mon, 29 Mar 2021 23:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617060609; bh=EXL/V1f5671ULe9zTlOxtZG5RkbkvreQBcphjnUfHMQ=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ggJZNBiqZH6NUsVc3Oncw91AnDIVjjOWzkNsXcbf0jOE90Q5R/JXggMzvZWpfBwub S3cUr3nh9Sl480xDXZAZdF6PhD7bEy7YAT506MxCU3ajEkSyv4Xwt4MQloiW3lMPfH SGBOKbPTYnJU1FxFdYita1HypGsxD6cNP1T+QLOGIi+kG1rPNvE1Ds860HnDpm1an0 g1QjR06eqLfCyTKoxBsQzlVHrtVnDoAQXN3Uu3SKlvyJByJcCZVhNKLtFceqnqW2f4 IQqkQwEIL5e1lBw81foyZ7HmLkalduQQDow7TiPqjxvo7u3P5TcUPpHgpTzwYOW9bs IzIanOdvWpSEg== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id 00F3760A48; Mon, 29 Mar 2021 23:30:09 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net:tipc: Fix a double free in tipc_sk_mcast_rcv From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161706060899.18537.8994477724999069966.git-patchwork-notify@kernel.org> Date: Mon, 29 Mar 2021 23:30:08 +0000 References: <20210328073029.4325-1-lyl2019@mail.ustc.edu.cn> In-Reply-To: <20210328073029.4325-1-lyl2019@mail.ustc.edu.cn> To: Lv Yunlong Cc: jmaloy@redhat.com, ying.xue@windriver.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Sun, 28 Mar 2021 00:30:29 -0700 you wrote: > In the if(skb_peek(arrvq) == skb) branch, it calls __skb_dequeue(arrvq) to get > the skb by skb = skb_peek(arrvq). Then __skb_dequeue() unlinks the skb from arrvq > and returns the skb which equals to skb_peek(arrvq). After __skb_dequeue(arrvq) > finished, the skb is freed by kfree_skb(__skb_dequeue(arrvq)) in the first time. > > Unfortunately, the same skb is freed in the second time by kfree_skb(skb) after > the branch completed. > > [...] Here is the summary with links: - net:tipc: Fix a double free in tipc_sk_mcast_rcv https://git.kernel.org/netdev/net/c/6bf24dc0cc0c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html