Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3978780pxf; Mon, 29 Mar 2021 17:31:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwB8Sg6EV3unqFM/1Wavw5I1qzRyYKyGfulx/ht+jXriD/FiJGesmTZPLSDN5riD04YkaKe X-Received: by 2002:aa7:cd0e:: with SMTP id b14mr31714020edw.354.1617064314895; Mon, 29 Mar 2021 17:31:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617064314; cv=none; d=google.com; s=arc-20160816; b=YiEb2GCfuHF3hnGGFy2lLRgzZQWcTzcFUnaf0GQE8k+k0NHNOx4iKA7hD36wGnHrX3 xeiD5OPxyGFEH4h5jwLTrWMuH2EvBrTy0NHtMMinezMsLnwMWmIMb+hS4hrjT3JdsWRN w7Sk9lJHNOFrSRovhQXkP5OnmQn0Ijx80pmEM/ER5mw7Ejgc60na59WuA8/6yncQ9kOp f/91Hb6jCrbBw8TmJa8vPxkYgA9/8fH5lcSHzSLFI50LT3/XarGS5mvzfMF5dd9sb/Nz tSj1UnuPbZTo5ftaHSToJdGx7PoUs7ZzVoiyGIl2KbETODmymzuwUPdLNWVUOpUKp8Mx yhZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=uudezhcW8eV9sngxzJklXbL/cI3CuGCgGNs5OAAOeA8=; b=oXlSG639oXVGeHjoYYXB6dGWR2yq1Kc2eQqSBFNgouJB5BZmQG8iCtjcsb4dNH1t1t CciGgVBO/pz4tPJb6A/4Xg1OvdfWoSJ+oV9YV9yW2jfhJRzE9UR1QBxvKIfhRUQlP1h2 4PqPnm2rIgmMONm9C83/ZiM6mTPTyfSfciZ44mVkNVmE/HfMbK13LTxE4Ys+28Jl7Lfa rdCuBBLZYAZT7JOc7ZF8eauqJM32daDEm9yABuAqFtBPtVl0L5bX2lRHYiP7c/6Zvrq+ hkL4yUk7nku4tQum41ty1j4Kt1aLPcbfAoT0+aaN5u8CeEcb6i5Mn9UI9hbnhGstKFjY uUFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZs8PZRu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x10si14260707ejs.610.2021.03.29.17.31.32; Mon, 29 Mar 2021 17:31:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oZs8PZRu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbhC3Aah (ORCPT + 99 others); Mon, 29 Mar 2021 20:30:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:53428 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229483AbhC3AaL (ORCPT ); Mon, 29 Mar 2021 20:30:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id 0612161987; Tue, 30 Mar 2021 00:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617064209; bh=qPsUwsxkHrWhgxeyPJd4F3z2LHyi86XM2kE6x0RHwjo=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=oZs8PZRuZ7/U+zqMS0GqUQXoWjuMrPdHCcEaEfIYI7rKJ04C9+700ZJq1yOwJLVtz HlyaGMoQuYWrUkAlNAUqnknNpT2O6a8zgMFAIG7adrAi9WmkZMwMXs7l3LGpL3Ao7t WW8AoSQsQyMeiTNnxQwEhekzqrppFFioyZTF43xbW9RTIBrWnnrfFRKuOo/0L0f7iL MNl06ppTQIUuH+86Vs8ErWD+SitH7zfdl+GQCcESTEPA0hBX1hBQqE4hjZLJcY9xcq +yPPuoFrbvePzHHdMs+bxGIrWbvLdzD9W2TKrGz/wMxhROce+HANtV3BJdKpyeub88 7As8BmhtqWaTQ== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id E7E3160A48; Tue, 30 Mar 2021 00:30:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ethernet/netronome/nfp: Fix a use after free in nfp_bpf_ctrl_msg_rx From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161706420894.10022.11354117385100184224.git-patchwork-notify@kernel.org> Date: Tue, 30 Mar 2021 00:30:08 +0000 References: <20210329115002.8557-1-lyl2019@mail.ustc.edu.cn> In-Reply-To: <20210329115002.8557-1-lyl2019@mail.ustc.edu.cn> To: Lv Yunlong Cc: kuba@kernel.org, simon.horman@netronome.com, davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, oss-drivers@netronome.com, linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 29 Mar 2021 04:50:02 -0700 you wrote: > In nfp_bpf_ctrl_msg_rx, if > nfp_ccm_get_type(skb) == NFP_CCM_TYPE_BPF_BPF_EVENT is true, the skb > will be freed. But the skb is still used by nfp_ccm_rx(&bpf->ccm, skb). > > My patch adds a return when the skb was freed. > > Fixes: bcf0cafab44fd ("nfp: split out common control message handling code") > Signed-off-by: Lv Yunlong > > [...] Here is the summary with links: - ethernet/netronome/nfp: Fix a use after free in nfp_bpf_ctrl_msg_rx https://git.kernel.org/netdev/net/c/6e5a03bcba44 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html