Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4044490pxf; Mon, 29 Mar 2021 19:55:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyocOWOQLyc8xOIOzf6uYs/Z3UKMsyfKCqH4VtgqD/YMABsqHdEwffZNIjGPUGKsctqK8iC X-Received: by 2002:aa7:cb0a:: with SMTP id s10mr31071212edt.36.1617072934705; Mon, 29 Mar 2021 19:55:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617072934; cv=none; d=google.com; s=arc-20160816; b=mqUg8FTsj3X8u4a85kskvscHy2T0A7NiJzVN7NLiAh8qJTgAfzZlJQw0fJrtNUvQ2G eF22wIeTb++ghzbUQyirQ0T7k6KZRpEKPUTC6hrlE4yOZ4yZky0aQUc7Liu1Adf17tX3 QJ6Jh23LGuBw6M5fHR9By3wDrttpq+kj8RJbKA+SGz7LHKn7y5DpFixDviiGiHpjsokM bWEf22OIJ7P/7BY7AZXe0QcIbS9dG9quvuRYHTXbj+S/SBR+YCxi2RW6UP6vOdUfy7uy GCGVtxmCc/nn1WzZsrGKT6diXayFU3u5pNozksOMk8ygHiqpgq7Cw6xU6vxA+FYgFjJL XhQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Pyzpcly5+oL22ifqA9LcP9BWqlXKnbYel2OHd9y5j2k=; b=vCqPdUmFo453JwZ5OIbXwTS3WHlERxAZMBsoIXQi5Z77b64w2jN+fcELz6xmv3vlml 7n58bDOVBP/1u6QntResxNqEXEcGOxM8NkX1LCDVzOI0+bodq3Z6cosbSg2EeqHHsfns wNpAUcxtNEjPEeprmKd67y4Pe4AsEBYsgQxsidXpga8XWk0E8WHgYzFuSuIMkpkvXjbx U/5mguaszexPJhtgWcYPfGNMgZV/BbiE4bb1ZY0WcRoPCckizrYl3jwKHlQeHS9WsXNZ AxZzJ/V0Cts1vmSaFaQSUeW115FunGVNQzPzF6BF2S+Dh3JFao6tBHyaMgil+5f06EjI W/Xg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kvMdz9ZB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si13466570ejg.677.2021.03.29.19.55.12; Mon, 29 Mar 2021 19:55:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=kvMdz9ZB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230373AbhC3CyR (ORCPT + 99 others); Mon, 29 Mar 2021 22:54:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36346 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229911AbhC3CyB (ORCPT ); Mon, 29 Mar 2021 22:54:01 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1941FC061764 for ; Mon, 29 Mar 2021 19:54:01 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id f10so10663286pgl.9 for ; Mon, 29 Mar 2021 19:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Pyzpcly5+oL22ifqA9LcP9BWqlXKnbYel2OHd9y5j2k=; b=kvMdz9ZBBO2CD3j+PC6tdVvNoYqpgwii81QhShzrYQgX8quKvl6YgQEHZtzMQ4wyZM GSfXE8Q2D4AECcXNk+RA7NWljGszHvrR11DgRy0GA0mIXlhx8DYWJMVsKIttJwLT0Es5 m/5ZuBbBDE3VdZqM4XsmavbD8gkXnU1kozoX0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Pyzpcly5+oL22ifqA9LcP9BWqlXKnbYel2OHd9y5j2k=; b=KYNzeYoZC//OBwKElCFYkco3Iz+bL+9xajF4CZNXBmdLd4+fa0FSr+31RznNyZwVy0 Uc0SaxFFrINNlmYvKVlJHrvG1n8e50cOPUO8H92CNagX8dl7SQZRu4Zq2RLc7mHpyRJK axG25WlSBCDxIeL5pkDmpczOJoTB6+sBh0oNx3G4t/FgTSkK/DWrYHTU7hAtFdgjWL+x N8pKLbmLsVf8l2RNfnbvEZc9QRUHc3IBrJf7KsrP6+JOj3kYWtCU8ItuI4xWHZD5AuYq K3tYgGc/jQw4gcWti9Sm2+pr2Z4CRum5JHRvpg1J0VY9dTnIKPrpM3Yi+dpPHv4gVUX3 zBOw== X-Gm-Message-State: AOAM533AVrD5o4+19UYhXArnxcWyvPiSfomTEGLNFwHUmLRE1y7W/o9o Zdq3x+1dRWupBRwsUUQNgT6lXQ== X-Received: by 2002:a63:1e56:: with SMTP id p22mr26342059pgm.375.1617072840452; Mon, 29 Mar 2021 19:54:00 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:f599:1ca7:742d:6b50]) by smtp.gmail.com with ESMTPSA id t17sm19152706pgk.25.2021.03.29.19.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 19:54:00 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg Cc: Bjorn Andersson , Stephen Boyd , Maarten Lankhorst , robdclark@chromium.org, Stanislav Lisovskiy , linux-arm-msm@vger.kernel.org, Steev Klimaszewski , Linus W , Douglas Anderson , Boris Brezillon , Daniel Vetter , David Airlie , Laurent Pinchart , Maxime Ripard , Robert Foss , Thierry Reding , Thomas Zimmermann , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 00/14] drm: Fix EDID reading on ti-sn65dsi86 Date: Mon, 29 Mar 2021 19:53:31 -0700 Message-Id: <20210330025345.3980086-1-dianders@chromium.org> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The primary goal of this series is to try to properly fix EDID reading for eDP panels using the ti-sn65dsi86 bridge. Previously we had a patch that added EDID reading but it turned out not to work at bootup. This caused some extra churn at bootup as we tried (and failed) to read the EDID several times and also ended up forcing us to use the hardcoded mode at boot. With this patch series I believe EDID reading is reliable at boot now and we never use the hardcoded mode. This series is the logical successor to the 3-part series containing the patch ("drm/bridge: ti-sn65dsi86: Properly get the EDID, but only if refclk") [1] though only one actual patch is the same between the two. This series starts out with some general / obvious fixes and moves on to some more specific and maybe controversial ones. I wouldn't object to some of the earlier ones landing if they look ready. This patch was developed against drm-misc-next on a sc7180-trogdor-lazor device. To get things booting for me, I had to use Stephen's patch [2] to keep from crashing but otherwise all the patches I needed were here. [1] https://lore.kernel.org/r/20210304155144.3.I60a7fb23ce4589006bc95c64ab8d15c74b876e68@changeid/ [2] https://lore.kernel.org/r/161706912161.3012082.17313817257247946143@swboyd.mtv.corp.google.com/ Changes in v2: - Removed 2nd paragraph in commit message. Douglas Anderson (14): drm/bridge: Fix the stop condition of drm_bridge_chain_pre_enable() drm/bridge: ti-sn65dsi86: Simplify refclk handling drm/bridge: ti-sn65dsi86: Remove incorrectly tagged kerneldoc comment drm/bridge: ti-sn65dsi86: Reorder remove() drm/bridge: ti-sn65dsi86: Move MIPI detach() / unregister() to detach() drm/bridge: ti-sn65dsi86: Move drm_panel_unprepare() to post_disable() drm/bridge: ti-sn65dsi86: Get rid of the useless detect() function drm/bridge: ti-sn65dsi86: Remove extra call: drm_connector_update_edid_property() drm/edid: Use the cached EDID in drm_get_edid() if eDP drm/bridge: ti-sn65dsi86: Stop caching the EDID ourselves drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID drm/bridge: ti-sn65dsi86: Read the EDID only if refclk was provided drm/bridge: ti-sn65dsi86: Print an error if we fallback to panel modes drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare drivers/gpu/drm/bridge/ti-sn65dsi86.c | 125 ++++++++++++++++---------- drivers/gpu/drm/drm_bridge.c | 3 + drivers/gpu/drm/drm_edid.c | 32 ++++++- drivers/gpu/drm/panel/Kconfig | 1 + drivers/gpu/drm/panel/panel-simple.c | 93 ++++++++++++++----- 5 files changed, 184 insertions(+), 70 deletions(-) -- 2.31.0.291.g576ba9dcdaf-goog