Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4044542pxf; Mon, 29 Mar 2021 19:55:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw5Di9+JYsPWHRjCHdVesBXB4Bspex6dkEHQfhTME/qiBO/oPaDX1m+CzK0F8BhnR1ksulC X-Received: by 2002:a05:6402:350f:: with SMTP id b15mr31216820edd.6.1617072944113; Mon, 29 Mar 2021 19:55:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617072944; cv=none; d=google.com; s=arc-20160816; b=MQVvdubJ0A7Pv4uOemJ1HxV+nmrpDLLmqwv75MkyL0gFy5g8MAgqjUGXdP88gFO5Pa 62yB0AF1Z4yRmrtPAw1oFsUbLIxFnhFsgn0MZxM+6+m6+VJbi6pvwDswD6kEvQ22brmZ xUFclE1PyFKdNhFuapiGV0fq49sxVYTYNa6J47aZQNaVxOb2cngy+Ota65Of4rp1CtEB qTiCIgr5wfdac/qTi1HvIvMIB/VR4CKpCkc4/mTziTxg8HJ/9LPk0+L7wq5T4KShN5cV oxxuxs55is+fbn+0veHVzN4i800a2zauPPow0bJBB30Y4gZiEuVXqs/wk6j8Dwlggsao mBbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=RTm+OMgZlY4S4hMjr1yPchfjYIhYww8IVvy3C+UG5OA=; b=hmCpyctH89mExvz9vWyezPKvLcyhw9yetr7RpjsheXhgFoVFM9pswanJ4u87hKhbtN Be2eNnxKJ5aDYDF0Zp48K3KeXrY6IvPUNkSFEd9boxMvnZ+c1vPvFUrgpwFTW0pMY5C4 nHdgU//5fdyE7UMJWBSTegF5OW1Y+v2EknkKdkv/cqbmMp20+djXEULQOhVhCKLePcrP wFHWwzD3MntJFvKPWan9q66D0AKeKIqSJHD6FW6+gdhdoxxv1Xn/e3hIek+NlrqjC+Ex Ns0HLGxpxBe/fLtRIO+WOs/Q34Q+ytYsgCpkVSp7GixlvUn/s9lyaB0BKIKcirwA49hy 2YNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T1ak2WvH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y9si14405126edi.0.2021.03.29.19.55.21; Mon, 29 Mar 2021 19:55:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=T1ak2WvH; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231420AbhC3Cy1 (ORCPT + 99 others); Mon, 29 Mar 2021 22:54:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231192AbhC3CyN (ORCPT ); Mon, 29 Mar 2021 22:54:13 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56B7EC061762 for ; Mon, 29 Mar 2021 19:54:13 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id k23-20020a17090a5917b02901043e35ad4aso8696140pji.3 for ; Mon, 29 Mar 2021 19:54:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RTm+OMgZlY4S4hMjr1yPchfjYIhYww8IVvy3C+UG5OA=; b=T1ak2WvHBXzGIQK+L+Lq+8Ydsiyy7SAzW87e3YZAJR0P9M2cVBxpRS3kXSX/3+bAS0 TyMOb6na5z7J4n+mnK9vwZIY4JmI8LfiedI1xE35JhEQDHzTm2Lv0g/CEOrM11JzFBPi J7Pzn6F79MaPYrGkaO7mXaxVycYLvdbRyGHns= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RTm+OMgZlY4S4hMjr1yPchfjYIhYww8IVvy3C+UG5OA=; b=iHN4zWAgo2Cyod0c0dX7lsdgAzMHtXuzd2fB46QUVp2p7P/EuL8ZfblivHI5+WTH9j GMRgUR/ThZt+Fg4Go4YNpbMQSz78J+ibV4d335+kpjf9W7d8+aT2tgEWwA1HQuGHrrmD rj9XGNb7iTy0jPIUGJLpLaq2t7lFIKkORVG53h254aZMleX5KkkQR7UfLFKjqkUkDY0m iUAsJWXcCthmudAf8XPVpf7nvXPUiOzHI2MWy3bsoJswtlT3/GI78B6BzKlpza9ZUAPc EuK3Qz4oiOvNVa0WBhBokJffrVgQs8KXCd1GQsFHSw3Y3NNDoY0MUCCcJtk34fQHuXWF WDzA== X-Gm-Message-State: AOAM531bqAmReQeA+aMsjXrLtPpkqJ07Dmuc04VC1yQ0X1kefPf9MhZU QMYotmJ+46nkj2+j5Z7rNqkacA== X-Received: by 2002:a17:902:f54e:b029:e6:3d74:eb3 with SMTP id h14-20020a170902f54eb02900e63d740eb3mr31652296plf.14.1617072852935; Mon, 29 Mar 2021 19:54:12 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:201:f599:1ca7:742d:6b50]) by smtp.gmail.com with ESMTPSA id t17sm19152706pgk.25.2021.03.29.19.54.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Mar 2021 19:54:12 -0700 (PDT) From: Douglas Anderson To: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg Cc: Bjorn Andersson , Stephen Boyd , Maarten Lankhorst , robdclark@chromium.org, Stanislav Lisovskiy , linux-arm-msm@vger.kernel.org, Steev Klimaszewski , Linus W , Douglas Anderson , Daniel Vetter , David Airlie , Robert Foss , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 07/14] drm/bridge: ti-sn65dsi86: Get rid of the useless detect() function Date: Mon, 29 Mar 2021 19:53:38 -0700 Message-Id: <20210329195255.v2.7.I826adf4faeb7f39f560b387f6b380e639c6986c8@changeid> X-Mailer: git-send-email 2.31.0.291.g576ba9dcdaf-goog In-Reply-To: <20210330025345.3980086-1-dianders@chromium.org> References: <20210330025345.3980086-1-dianders@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we just leave the detect() function as NULL then the upper layers assume we're always connected. There's no reason for a stub. Signed-off-by: Douglas Anderson --- (no changes since v1) drivers/gpu/drm/bridge/ti-sn65dsi86.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 50a52af8e39f..a0a00dd1187c 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -306,20 +306,8 @@ static struct drm_connector_helper_funcs ti_sn_bridge_connector_helper_funcs = { .mode_valid = ti_sn_bridge_connector_mode_valid, }; -static enum drm_connector_status -ti_sn_bridge_connector_detect(struct drm_connector *connector, bool force) -{ - /** - * TODO: Currently if drm_panel is present, then always - * return the status as connected. Need to add support to detect - * device state for hot pluggable scenarios. - */ - return connector_status_connected; -} - static const struct drm_connector_funcs ti_sn_bridge_connector_funcs = { .fill_modes = drm_helper_probe_single_connector_modes, - .detect = ti_sn_bridge_connector_detect, .destroy = drm_connector_cleanup, .reset = drm_atomic_helper_connector_reset, .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, -- 2.31.0.291.g576ba9dcdaf-goog