Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     Wang Qing <wangqing@vivo.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: cdns3: delete repeated clear operations
Thread-Topic: [PATCH] usb: cdns3: delete repeated clear operations
Thread-Index: AQHXF7JuMXLfB7vBtEWzzBA5XVJ5+KqPpe5AgAdyfICABOU2EA==
Date:   Tue, 30 Mar 2021 03:43:13 +0000
Message-ID: <BYAPR07MB5381B69A36E6523A9EF02703DD7D9@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <1615603303-14518-1-git-send-email-wangqing@vivo.com>
 <BYAPR07MB5381E439E54E87C91086BA07DD659@BYAPR07MB5381.namprd07.prod.outlook.com>
 <20210327005539.GC28870@b29397-desktop>
In-Reply-To: <20210327005539.GC28870@b29397-desktop>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 65538aa8-44fb-402d-170f-08d8f32df25e
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 03:43:13.7586
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +JLgMj/GnYY28yGTRHz+VJDfJOw3xvVr5q0VIYwxh9mMoUj5zdOHRTpqc0HQdIKuMWT+2Dmx1HzilwEpZINLHW6LaG1zT2at/uAd0ObAf1k=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB4421
X-Proofpoint-ORIG-GUID: xDTnoFUCk1Yp5ahBzsIxIonwNvbbAuHD
X-Proofpoint-GUID: xDTnoFUCk1Yp5ahBzsIxIonwNvbbAuHD
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-30_01:2021-03-26,2021-03-30 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 suspectscore=0
 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 lowpriorityscore=0
 phishscore=0 mlxscore=0 impostorscore=0 priorityscore=1501 clxscore=1015
 mlxlogscore=816 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2103250000 definitions=main-2103300023
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>
>On 21-03-22 07:19:46, Pawel Laszczak wrote:
>> Hi Peter,
>>
>> Can you add this patch to for-usb-next branch.
>>
>
>Feel free add your ACK base on this patch.
>
>Peter
>> Thanks.
>>
>> >
>> >
>> >dma_alloc_coherent already zeroes out memory, so memset is not needed.
>> >
>> >Signed-off-by: Wang Qing <wangqing@vivo.com>
>>
>> Reviewed-by: Pawel Laszczak <pawell@cadence.com>


Acked-by: Pawel Laszczak <pawell@cadence.com>

>>
>> >---
>> > drivers/usb/cdns3/cdnsp-mem.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> >diff --git a/drivers/usb/cdns3/cdnsp-mem.c b/drivers/usb/cdns3/cdnsp-me=
m.c
>> >index 7a84e92..1d1b9a4
>> >--- a/drivers/usb/cdns3/cdnsp-mem.c
>> >+++ b/drivers/usb/cdns3/cdnsp-mem.c
>> >@@ -1231,7 +1231,6 @@ int cdnsp_mem_init(struct cdnsp_device *pdev)
>> > 	if (!pdev->dcbaa)
>> > 		return -ENOMEM;
>> >
>> >-	memset(pdev->dcbaa, 0, sizeof(*pdev->dcbaa));
>> > 	pdev->dcbaa->dma =3D dma;
>> >
>> > 	cdnsp_write_64(dma, &pdev->op_regs->dcbaa_ptr);
>> >--
>> >2.7.4
>>
>> Regards,
>> Pawel Laszczak
>
>--
>
>Thanks,
>Peter Chen

Regards,
Pawel Laszczak