Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     Peter Chen <peter.chen@kernel.org>
CC:     "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH] usb: cdnsp: Fixes issue with Configure Endpoint command
Thread-Topic: [PATCH] usb: cdnsp: Fixes issue with Configure Endpoint command
Thread-Index: AQHXHuHlWR6DFE1h2U6zYwJk4ihkfqqXCamAgATvxhA=
Date:   Tue, 30 Mar 2021 04:26:10 +0000
Message-ID: <BYAPR07MB53814609AA96C16D6432761DDD7D9@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20210322060902.11197-1-pawell@gli-login.cadence.com>
 <20210327005417.GB28870@b29397-desktop>
In-Reply-To: <20210327005417.GB28870@b29397-desktop>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 2ca70b12-bd8e-40e7-a7a1-08d8f333f235
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2021 04:26:10.3727
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9MXFDr2iCn99jKg7hZQ3Gji1YnUQtzZJhGxVFip4aZfw92EZM62rHAg99YAoHFrnNu2wVYlOUbreN8OUijg+mTqZV7KTP9ndgo2pf0H0C7A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5766
X-Proofpoint-ORIG-GUID: nfZ0rQaLD0szzATjiLSQKjKpK7n0pZT_
X-Proofpoint-GUID: nfZ0rQaLD0szzATjiLSQKjKpK7n0pZT_
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-30_01:2021-03-26,2021-03-30 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 phishscore=0
 mlxlogscore=732 adultscore=0 suspectscore=0 bulkscore=0 malwarescore=0
 priorityscore=1501 mlxscore=0 spamscore=0 clxscore=1015 impostorscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2103250000 definitions=main-2103300027
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

>
>On 21-03-22 07:09:02, Pawel Laszczak wrote:
>> From: Pawel Laszczak <pawell@cadence.com>
>>
>> Patch adds flag EP_UNCONFIGURED to detect whether endpoint was
>> unconfigured. This flag is set in cdnsp_reset_device after Reset Device
>> command. Among others this command disables all non control endpoints.
>> Flag is used in cdnsp_gadget_ep_disable to protect controller against
>> invoking Configure Endpoint command on disabled endpoint. Lack of this
>> protection in some cases caused that Configure Endpoint command complete=
d
>> with Context State Error code completion.
>>
>> Fixes: 3d82904559f4 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP =
DRD Driver")
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>>  drivers/usb/cdns3/cdnsp-gadget.c | 18 +++++++++++++-----
>>  drivers/usb/cdns3/cdnsp-gadget.h | 11 ++++++-----
>>  2 files changed, 19 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/cdnsp-gadget.c b/drivers/usb/cdns3/cdnsp-=
gadget.c
>> index d7d4bdd57f46..de17cc4ad91a 100644
>> --- a/drivers/usb/cdns3/cdnsp-gadget.c
>> +++ b/drivers/usb/cdns3/cdnsp-gadget.c
>> @@ -727,7 +727,7 @@ int cdnsp_reset_device(struct cdnsp_device *pdev)
>>  	 * are in Disabled state.
>>  	 */
>>  	for (i =3D 1; i < CDNSP_ENDPOINTS_NUM; ++i)
>> -		pdev->eps[i].ep_state |=3D EP_STOPPED;
>> +		pdev->eps[i].ep_state |=3D EP_STOPPED | EP_UNCONFIGURED;
>>
>>  	trace_cdnsp_handle_cmd_reset_dev(slot_ctx);
>>
>> @@ -942,6 +942,7 @@ static int cdnsp_gadget_ep_enable(struct usb_ep *ep,
>>
>>  	pep =3D to_cdnsp_ep(ep);
>>  	pdev =3D pep->pdev;
>> +	pep->ep_state &=3D ~EP_UNCONFIGURED;
>>
>>  	if (dev_WARN_ONCE(pdev->dev, pep->ep_state & EP_ENABLED,
>>  			  "%s is already enabled\n", pep->name))
>> @@ -1023,9 +1024,13 @@ static int cdnsp_gadget_ep_disable(struct usb_ep =
*ep)
>>  		goto finish;
>>  	}
>>
>> -	cdnsp_cmd_stop_ep(pdev, pep);
>>  	pep->ep_state |=3D EP_DIS_IN_RROGRESS;
>> -	cdnsp_cmd_flush_ep(pdev, pep);
>> +
>> +	/* Endpoint was unconfigured by Reset Device command. */
>> +	if (!(pep->ep_state & EP_UNCONFIGURED)) {
>> +		cdnsp_cmd_stop_ep(pdev, pep);
>> +		cdnsp_cmd_flush_ep(pdev, pep);
>> +	}
>>
>>  	/* Remove all queued USB requests. */
>>  	while (!list_empty(&pep->pending_list)) {
>> @@ -1036,6 +1041,7 @@ static int cdnsp_gadget_ep_disable(struct usb_ep *=
ep)
>>  	cdnsp_invalidate_ep_events(pdev, pep);
>>
>>  	pep->ep_state &=3D ~EP_DIS_IN_RROGRESS;
>> +
>
>Useless blank line
>
>>  	drop_flag =3D cdnsp_get_endpoint_flag(pep->endpoint.desc);
>>  	ctrl_ctx =3D cdnsp_get_input_control_ctx(&pdev->in_ctx);
>>  	ctrl_ctx->drop_flags =3D cpu_to_le32(drop_flag);
>> @@ -1043,10 +1049,12 @@ static int cdnsp_gadget_ep_disable(struct usb_ep=
 *ep)
>>
>>  	cdnsp_endpoint_zero(pdev, pep);
>>
>> -	ret =3D cdnsp_update_eps_configuration(pdev, pep);
>> +	if (!(pep->ep_state & EP_UNCONFIGURED))
>> +		ret =3D cdnsp_update_eps_configuration(pdev, pep);
>> +
>>  	cdnsp_free_endpoint_rings(pdev, pep);
>>
>> -	pep->ep_state &=3D ~EP_ENABLED;
>> +	pep->ep_state &=3D ~(EP_ENABLED | EP_UNCONFIGURED);
>>  	pep->ep_state |=3D EP_STOPPED;
>>
>>  finish:
>> diff --git a/drivers/usb/cdns3/cdnsp-gadget.h b/drivers/usb/cdns3/cdnsp-=
gadget.h
>> index 6bbb26548c04..e628bd539e23 100644
>> --- a/drivers/usb/cdns3/cdnsp-gadget.h
>> +++ b/drivers/usb/cdns3/cdnsp-gadget.h
>> @@ -830,11 +830,12 @@ struct cdnsp_ep {
>>  	unsigned int ep_state;
>>  #define EP_ENABLED		BIT(0)
>>  #define EP_DIS_IN_RROGRESS	BIT(1)
>> -#define EP_HALTED		BIT(2)
>> -#define EP_STOPPED		BIT(3)
>> -#define EP_WEDGE		BIT(4)
>> -#define EP0_HALTED_STATUS	BIT(5)
>> -#define EP_HAS_STREAMS		BIT(6)
>> +#define EP_UNCONFIGURED		BIT(2)
>
>Why add new flag as BIT(2), it causes many changes in this patch?

In my feeling, EP_UNCONFIGURED is more associates with the first 2 flags, s=
o I've decided=20
put it after BIT(1). =20

>
>> +#define EP_HALTED		BIT(3)
>> +#define EP_STOPPED		BIT(4)
>> +#define EP_WEDGE		BIT(5)
>> +#define EP0_HALTED_STATUS	BIT(6)
>> +#define EP_HAS_STREAMS		BIT(7)
>>
>>  	bool skip;
>>  };
>> --
>> 2.25.1
>>
>
>--
>
>Thanks,
>Peter Chen