Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Heiko Thiery <heiko.thiery@gmail.com>
To:     jisheng.zhang@synaptics.com
Cc:     jens.wiklander@linaro.org, linux-kernel@vger.kernel.org,
        linux@roeck-us.net, op-tee@lists.trustedfirmware.org,
        rostedt@goodmis.org, Heiko Thiery <heiko.thiery@gmail.com>
Subject: Re: [PATCH] tee: optee: fix build error caused by recent optee tracepoints feature
Date:   Tue, 30 Mar 2021 08:53:42 +0200
Message-Id: <20210330065341.18074-1-heiko.thiery@gmail.com>
In-Reply-To: <20210325120601.71584253@xhacker.debian>
References: <20210325120601.71584253@xhacker.debian>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

> If build kernel without "O=dir", below error will be seen:
> 
> In file included from drivers/tee/optee/optee_trace.h:67,
>                  from drivers/tee/optee/call.c:18:
> ./include/trace/define_trace.h:95:42: fatal error: ./optee_trace.h: No such file or directory
>    95 | #include TRACE_INCLUDE(TRACE_INCLUDE_FILE)
>       |                                          ^
> compilation terminated.
> 
> Fix it by adding below line to Makefile:
> CFLAGS_call.o := -I$(src)
> 
> Tested with and without "O=dir", both can build successfully.
> 
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Suggested-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>

Fixes: 0101947dbcc3 ("tee: optee: add invoke_fn tracepoints")
Tested-by: Heiko Thiery <heiko.thiery@gmail.com>

> ---
>  drivers/tee/optee/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/tee/optee/Makefile b/drivers/tee/optee/Makefile
> index 56263ae3b1d7..3aa33ea9e6a6 100644
> --- a/drivers/tee/optee/Makefile
> +++ b/drivers/tee/optee/Makefile
> @@ -6,3 +6,6 @@ optee-objs += rpc.o
>  optee-objs += supp.o
>  optee-objs += shm_pool.o
>  optee-objs += device.o
> +
> +# for tracing framework to find optee_trace.h
> +CFLAGS_call.o := -I$(src)
> -- 
> 2.31.0
> 

Thank you.

-- 
Heiko