Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4156134pxf; Tue, 30 Mar 2021 00:07:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxCNrdVzaTbw5LyJrZCCESB5+HhiTxjMGIF9u1iOrsfQOUUTYkFfzEP+LJyYNgW3gk3SDlD X-Received: by 2002:a17:907:75c7:: with SMTP id jl7mr33269214ejc.191.1617088047961; Tue, 30 Mar 2021 00:07:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617088047; cv=none; d=google.com; s=arc-20160816; b=e+qIctFJDdm+gvuUL0OFHaXDk4ZkKtW10R02tENns1bm8iPuwpiFv9/XD87AKTgAvD RrUsynadBGfpO1zo/Je3t3FV5pem6pDFkmtUHuXnl+liktMIJ/80cXbfm0autZFNeLKG IAg/3DhZMj6T8oHv6KgNmdcb/Wj/LZV2AKxkn8lKXp+GwcZKhcsV6XS0vpMlL4hTIxs+ 1eWbU2hmvzBeNEqGjXvXFdDK4IArIMJavj6bxRyxW7hb4qtnVxMr6SoqtwBOA/MGbsmG jb0Ik4apILj5uX3lfjecW6ZECebC2+VTQ6dcqPmYY9CCTHK4mUXf7fWnOwaYay9uiwB+ A/1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from; bh=wqc4FLXhYpFbaAZqsK0+Pp3tXZaZYVXvGqWKTrx9q6U=; b=C3PK/ua28vHYhVemMIr4lLgcA6OnaHe6s9yU1DslPdFEGZoD9Yw8VSUxsmsToee1mj h0z53HSjzqyLgpTCoTwJeCDW2bt5wq64DmJtaJ9m1rcyKZsbmGkCUuKEq2nqSmI/9z2A i/xUZ2/vFevl/CZcwMgpuj6pOI9eRJpPpQapVf3BSSV2fuRR5o8N5dkFy8cWy1PIsL12 FkEZZF8O3cjkJek/hNHSRLoPF+6D7XaQE4oPJzRry4F0HI72oXehU17+TgQeSV4zr/Tm J/pABcpzT0OarkIAnw56nzX28aL7l1Vjt0XIzb1R5Qnszy18zvZFK7pcW4fDC/BPrK8j 9YqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 26si14059633ejy.13.2021.03.30.00.07.04; Tue, 30 Mar 2021 00:07:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231424AbhC3HGH (ORCPT + 99 others); Tue, 30 Mar 2021 03:06:07 -0400 Received: from mail-m118208.qiye.163.com ([115.236.118.208]:36804 "EHLO mail-m118208.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230316AbhC3HFk (ORCPT ); Tue, 30 Mar 2021 03:05:40 -0400 Received: from vivo-HP-ProDesk-680-G4-PCI-MT.vivo.xyz (unknown [58.251.74.232]) by mail-m118208.qiye.163.com (Hmail) with ESMTPA id F3B90E022C; Tue, 30 Mar 2021 15:05:27 +0800 (CST) From: Wang Qing To: Thomas Bogendoerfer , Adaptec OEM Raid Solutions , "James E.J. Bottomley" , "Martin K. Petersen" , Luis de Bethencourt , Salah Triki , David Woodhouse , Richard Weinberger , Ralf Baechle , "David S. Miller" , Jakub Kicinski , Wang Qing , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mtd@lists.infradead.org, linux-hams@vger.kernel.org, netdev@vger.kernel.org, linux-decnet-user@lists.sourceforge.net Cc: gregkh@linuxfoundation.org Subject: [PATCH 5/6] net/ax25: Delete obsolete TODO file Date: Tue, 30 Mar 2021 15:02:48 +0800 Message-Id: <1617087773-7183-6-git-send-email-wangqing@vivo.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1617087773-7183-1-git-send-email-wangqing@vivo.com> References: <1617087773-7183-1-git-send-email-wangqing@vivo.com> X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZHUhMTU9DT0pLGkseVkpNSkxLQ0xCSUNDSExVEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKQ1VLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NCo6Axw5ND8SEjdNLh1WTikW NB4aCklVSlVKTUpMS0NMQklCSkxNVTMWGhIXVQwaFRwKEhUcOw0SDRRVGBQWRVlXWRILWUFZTkNV SU5KVUxPVUlISVlXWQgBWUFITkpONwY+ X-HM-Tid: 0a7881f399782c17kusnf3b90e022c Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The TODO file here has not been updated for 13 years, and the function development described in the file have been implemented or abandoned. Its existence will mislead developers seeking to view outdated information. Signed-off-by: Wang Qing --- net/ax25/TODO | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 net/ax25/TODO diff --git a/net/ax25/TODO b/net/ax25/TODO deleted file mode 100644 index 69fb4e3..0000000 --- a/net/ax25/TODO +++ /dev/null @@ -1,20 +0,0 @@ -Do the ax25_list_lock, ax25_dev_lock, linkfail_lockreally, ax25_frag_lock and -listen_lock have to be bh-safe? - -Do the netrom and rose locks have to be bh-safe? - -A device might be deleted after lookup in the SIOCADDRT ioctl but before it's -being used. - -Routes to a device being taken down might be deleted by ax25_rt_device_down -but added by somebody else before the device has been deleted fully. - -The ax25_rt_find_route synopsys is pervert but I somehow had to deal with -the race caused by the static variable in it's previous implementation. - -Implement proper socket locking in netrom and rose. - -Check socket locking when ax25_rcv is sending to raw sockets. In particular -ax25_send_to_raw() seems fishy. Heck - ax25_rcv is fishy. - -Handle XID and TEST frames properly. -- 2.7.4