Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: QOiXiy9v2yvWnu8splEZ7FCYjwOfZM9vsj+WkXS+Ez26JD7zAOsNo4nzyLB2nsJ/WVcL2p3uTd
 O0uYjcYzeP/WhLEfyD/Lbmvc+voqrTSDy0qTo7Om24f2skespBOB74BjMZpChKCSacFt0W++Pk
 jE+7GPbFvPCEFnbrIdeAb/v6OVaDpieiKwP3T+WBV6TwzB1t7uS2DRu6//8HbtBXpSBt2uWOz2
 E4aytVlV2W/oowrvLX+GN+pxdmYRPj6Zams5vQCQ/342xeshie3Ug3HEZZ8oklUiV8JxboZuC2
 H3U=
Message-ID: <2356027828f1fa424751e91e478ff4bc188e7f6d.camel@microchip.com>
Subject: Re: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct
 register operations
From:   Steen Hegelund <steen.hegelund@microchip.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Microchip UNG Driver List <UNGLinuxDriver@microchip.com>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Date:   Tue, 30 Mar 2021 10:18:44 +0200
In-Reply-To: <YGIimz9UnVYWfcXH@lunn.ch>
References: <20210329081438.558885-1-steen.hegelund@microchip.com>
         <20210329081438.558885-2-steen.hegelund@microchip.com>
         <YGIimz9UnVYWfcXH@lunn.ch>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Andrew,

On Mon, 2021-03-29 at 20:55 +0200, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> On Mon, Mar 29, 2021 at 10:14:38AM +0200, Steen Hegelund wrote:
> > Use direct register operations instead of a table of register
> > information to lower the stack usage.
> > 
> > Signed-off-by: Steen Hegelund <steen.hegelund@microchip.com>
> > Reported-by: kernel test robot <lkp@intel.com>
> > ---
> >  drivers/phy/microchip/sparx5_serdes.c | 1869 +++++++++++++------------
> >  1 file changed, 951 insertions(+), 918 deletions(-)
> > 
> > diff --git a/drivers/phy/microchip/sparx5_serdes.c b/drivers/phy/microchip/sparx5_serdes.c
> > index 06bcf0c166cf..43de68a62c2f 100644
> > --- a/drivers/phy/microchip/sparx5_serdes.c
> > +++ b/drivers/phy/microchip/sparx5_serdes.c
> > @@ -343,12 +343,6 @@ struct sparx5_sd10g28_params {
> >       u8 fx_100;
> >  };
> > 
> > -struct sparx5_serdes_regval {
> > -     u32 value;
> > -     u32 mask;
> > -     void __iomem *addr;
> > -};
> > -
> >  static struct sparx5_sd25g28_media_preset media_presets_25g[] = {
> >       { /* ETH_MEDIA_DEFAULT */
> >               .cfg_en_adv               = 0,
> > @@ -945,431 +939,411 @@ static void sparx5_sd25g28_reset(void __iomem *regs[],
> >       }
> >  }
> > 
> > -static int sparx5_sd25g28_apply_params(struct device *dev,
> > -                                    void __iomem *regs[],
> > -                                    struct sparx5_sd25g28_params *params,
> > -                                    u32 sd_index)
> > +static int sparx5_sd25g28_apply_params(struct sparx5_serdes_macro *macro,
> > +                                    struct sparx5_sd25g28_params *params)
> >  {
> > -     struct sparx5_serdes_regval item[] = {
> 
> Could you just add const here, and then it is no longer on the stack?
> 
>    Andrew

No it still counts against the stack even as a const structure.

BR
Steen