Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v1 0/5] mm/madvise: introduce MADV_POPULATE_(READ|WRITE)
 to prefault/prealloc memory
To:     linux-kernel@vger.kernel.org
Cc:     linux-mm@kvack.org, Andrea Arcangeli <aarcange@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Arnd Bergmann <arnd@arndb.de>, Chris Zankel <chris@zankel.net>,
        Dave Hansen <dave.hansen@intel.com>,
        Helge Deller <deller@gmx.de>, Hugh Dickins <hughd@google.com>,
        Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
        "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
        Jann Horn <jannh@google.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Linux API <linux-api@vger.kernel.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        Matt Turner <mattst88@gmail.com>,
        Max Filippov <jcmvbkbc@gmail.com>,
        "Michael S. Tsirkin" <mst@redhat.com>,
        Michal Hocko <mhocko@suse.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Minchan Kim <minchan@kernel.org>,
        Oscar Salvador <osalvador@suse.de>,
        Peter Xu <peterx@redhat.com>, Ram Pai <linuxram@us.ibm.com>,
        Richard Henderson <rth@twiddle.net>,
        Rik van Riel <riel@surriel.com>,
        Rolf Eike Beer <eike-kernel@sf-tec.de>,
        Shuah Khan <shuah@kernel.org>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Vlastimil Babka <vbabka@suse.cz>
References: <20210317110644.25343-1-david@redhat.com>
From:   David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <af5555cf-d112-44fd-e030-bfe8f89c8ddc@redhat.com>
Date:   Tue, 30 Mar 2021 10:58:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210317110644.25343-1-david@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 17.03.21 12:06, David Hildenbrand wrote:
> Excessive details on MADV_POPULATE_(READ|WRITE) can be found in patch #2.
> 
> Now accompanied by minor adjustments and selftests/vm tests.
> 
> RFCv2 -> v1
> - "mm: fix variable name in declaration of populate_vma_page_range()"
> -- Added
> - "mm/madvise: introduce MADV_POPULATE_(READ|WRITE) to prefault ..."
> -- Fix detection of memory holes when we have to re-lookup the VMA
> -- Return -EHWPOISON to user space when we hit HW poisoned pages
> -- Make variable names in definition and declaration consistent
> - "MAINTAINERS: add tools/testing/selftests/vm/ to MEMORY MANAGEMENT"
> -- Added
> - "selftests/vm: add protection_keys_32 / protection_keys_64 to gitignore"
> -- Added
> - "selftests/vm: add test for MADV_POPULATE_(READ|WRITE)"
> -- Added
> 
> RFC -> RFCv2:
> - Fix re-locking (-> set "locked = 1;")
> - Don't mimic MAP_POPULATE semantics:
> --> Explicit READ/WRITE request instead of selecting it automatically,
>      which makes it more generic and better suited for some use cases (e.g., we
>      usually want to prefault shmem writable)
> --> Require proper access permissions
> - Introduce and use faultin_vma_page_range()
> --> Properly handle HWPOISON pages (FOLL_HWPOISON)
> --> Require proper access permissions (!FOLL_FORCE)
> - Let faultin_vma_page_range() check for compatible mappings/permissions
> - Extend patch description and add some performance numbers
> 
> David Hildenbrand (5):
>    mm: make variable names for populate_vma_page_range() consistent
>    mm/madvise: introduce MADV_POPULATE_(READ|WRITE) to prefault/prealloc
>      memory
>    MAINTAINERS: add tools/testing/selftests/vm/ to MEMORY MANAGEMENT
>    selftests/vm: add protection_keys_32 / protection_keys_64 to gitignore
>    selftests/vm: add test for MADV_POPULATE_(READ|WRITE)
> 
>   MAINTAINERS                                |   1 +
>   arch/alpha/include/uapi/asm/mman.h         |   3 +
>   arch/mips/include/uapi/asm/mman.h          |   3 +
>   arch/parisc/include/uapi/asm/mman.h        |   3 +
>   arch/xtensa/include/uapi/asm/mman.h        |   3 +
>   include/uapi/asm-generic/mman-common.h     |   3 +
>   mm/gup.c                                   |  54 ++++
>   mm/internal.h                              |   5 +-
>   mm/madvise.c                               |  69 +++++
>   tools/testing/selftests/vm/.gitignore      |   3 +
>   tools/testing/selftests/vm/Makefile        |   1 +
>   tools/testing/selftests/vm/madv_populate.c | 342 +++++++++++++++++++++
>   tools/testing/selftests/vm/run_vmtests.sh  |  16 +
>   13 files changed, 505 insertions(+), 1 deletion(-)
>   create mode 100644 tools/testing/selftests/vm/madv_populate.c
> 

Gentle ping.

-- 
Thanks,

David / dhildenb