Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 0/2] soc: mediatek: Prepare MMSYS for DDP routing using
 tables
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        linux-kernel@vger.kernel.org
Cc:     drinkcat@chromium.org, hsinyi@chromium.org, weiyi.lu@mediatek.com,
        Collabora Kernel ML <kernel@collabora.com>,
        linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org
References: <20210317181711.795245-1-enric.balletbo@collabora.com>
From:   Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <9ae52157-c4b3-3080-6835-a6c4b349284a@gmail.com>
Date:   Tue, 30 Mar 2021 11:10:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210317181711.795245-1-enric.balletbo@collabora.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 17/03/2021 19:17, Enric Balletbo i Serra wrote:
> Dear all,
> 
> This is the second version of this series intended to prepare the
> mtk-mmsys driver to allow different DDP (Data Display Path) routing
> tables per SoC. Note that the series has been tested only on MT8173 platform,
> for MT2701 and MT2712 based devices we're using a default routing table
> that should just work.

That's a good base to improve the driver.
Things I'd like to see:

Split the mmsys_default_routing_table in the SoC specific one. But each SoC
specific routing table in a new header file.

Whole series applied to v5.12-next/soc

Thanks a lot!
Matthias

> 
> Thanks,
>   Enric
> 
> Changes in v2:
> - Use a default table for mt2701, mt2712 and mt8173.
> - Remove the mask field from routes struct as is not needed.
> 
> CK Hu (2):
>   soc: mediatek: mmsys: Create struct mtk_mmsys to store context data
>   soc: mediatek: mmsys: Use an array for setting the routing registers
> 
>  drivers/soc/mediatek/mtk-mmsys.c | 300 +++++--------------------------
>  drivers/soc/mediatek/mtk-mmsys.h | 215 ++++++++++++++++++++++
>  2 files changed, 257 insertions(+), 258 deletions(-)
>  create mode 100644 drivers/soc/mediatek/mtk-mmsys.h
>