Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?utf-8?Q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     devicetree@vger.kernel.org,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: RFC: dt-binding: media: document ON Semi AR0521 sensor bindings
References: <m3o8fjs02a.fsf@t19.piap.pl>
        <YFEBRGF20xhpHese@pendragon.ideasonboard.com>
Sender: khalasa@piap.pl
Date:   Tue, 30 Mar 2021 11:17:54 +0200
In-Reply-To: <YFEBRGF20xhpHese@pendragon.ideasonboard.com> (Laurent Pinchart's
        message of "Tue, 16 Mar 2021 21:04:36 +0200")
Message-ID: <m3czvhxanx.fsf@t19.piap.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Laurent Pinchart <laurent.pinchart@ideasonboard.com> writes:

>> +  reg:
>> +    description: I2C bus address of the sensor device
>
> You can drop this, it's implicit for I2C devices.

Do you mean just dropping these two lines (and MaxItems: 1), and leaving
"reg" in "required" and in the example? E.g.:
...
required:
  - compatible
  - reg
  - clocks
  - clock-names
  - port

additionalProperties: false

examples:
  - |
    #include <dt-bindings/gpio/gpio.h>
    #include <dt-bindings/clock/imx6qdl-clock.h>

    i2c {
            #address-cells =3D <1>;
            #size-cells =3D <0>;

            ar0521: camera-sensor@36 {
                    compatible =3D "onnn,ar0521";
                    reg =3D <0x36>;
                    pinctrl-names =3D "default";

...

It protests with:

Documentation/devicetree/bindings/media/i2c/onnn,ar0521.example.dt.yaml:
camera-sensor@36: 'reg' does not match any of the regexes: 'pinctrl-[0-9]+'
        From schema: /usr/src/linux/imx6/Documentation/devicetree/bindings/=
media/i2c/onnn,ar0521.yaml

Thus I'm currently leaving it as is.
--=20
Krzysztof Ha=C5=82asa

Sie=C4=87 Badawcza =C5=81ukasiewicz
Przemys=C5=82owy Instytut Automatyki i Pomiar=C3=B3w PIAP
Al. Jerozolimskie 202, 02-486 Warszawa