Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4227545pxf; Tue, 30 Mar 2021 02:31:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxW13QEh6fNFdOFBUJEOWinoBC3Xcdd5FZ0qVFl6RMUi5koPr98wMfX3O7rV/3KzFF7F3vZ X-Received: by 2002:a50:cdd1:: with SMTP id h17mr32686138edj.178.1617096689622; Tue, 30 Mar 2021 02:31:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617096689; cv=none; d=google.com; s=arc-20160816; b=yeAZUEbWZP9z/ClbYh3Sx9b5aAKm1Ln3j8EQz6rlB/U3i336WlqMIQM+RcgMW0Dan1 EyrNEx4mkh9iXASVgDRGabV+HrFBLmLwZ8nkEa7Bhktkv1czVhae/9P4F/mLvSSAta2k f4DAxAqFKlpAhJzCO+Q6v1D92XSiJNmTqW2ns3ZibcIbXLsqTpvmoHLn7Qh705JOpLdz FH3gzthkWtdVN7Y9YfYE4XKzrMcO+P4G4Wta9CRcXV+iKBoSNjDSEqUb77tRzHkSqkzx zb5cNIMpGKzSZmHpNW01pVvCLPb1mnkF9DzP9IaHEPJYkjUlmrnvkllpVDMSevG1K3IV FYaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=pdoDSSCbUQi2R8W8HM8Vue+cgmmwKQumE1/6QreOVx8=; b=rp6hrWb2SxE/i52d8BjUbcL5seslAbAw9kKcu9RIPn316tF9rhDe66w8obqWVoTfJu QlKbOK12XphnLWv756ymKOrPygp35AHgvtXr5r5FX/0WaV1Az6AC18mrZhEJLEk6GeZK PwFLHqj5uev8rYkpD8EOW9YfJ6OtAYbNBQHKPabj+Sr5LbbgFLspivIZmjXM6qVMA02H nZtcAsk4liKddMpkvhHyxFOq2lUX0WRXZlmwRXtecnK1KV07Bv5lDWqNoj7n8v2pcGox +C/ocpHHlURjMMs7BYqFf5jz4CWkSmj/5/YaOFEC5FFNiCIuU4GcnErTmsmidQmGRzYh rh0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si14337001edu.503.2021.03.30.02.31.07; Tue, 30 Mar 2021 02:31:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231814AbhC3J2S (ORCPT + 99 others); Tue, 30 Mar 2021 05:28:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:52474 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231872AbhC3J1z (ORCPT ); Tue, 30 Mar 2021 05:27:55 -0400 IronPort-SDR: FmLwIWdrycTjtCGU48IKsjORO2j0lFl9HMDPjOR7XdhzhS/TxZ6OQKXMa26uuXxEV32dhLd0WL +CJ4NH6Hrh0w== X-IronPort-AV: E=McAfee;i="6000,8403,9938"; a="191827894" X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="191827894" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 02:27:54 -0700 IronPort-SDR: NGyOk8Pq9GPJhyqKTMQnUVP/6Dn72a+jzNfj+ktA4nZvcWxCojhA9KpIYddOf8eQt9FOO3u2W0 zrhd909dW+og== X-IronPort-AV: E=Sophos;i="5.81,290,1610438400"; d="scan'208";a="445133425" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 02:27:52 -0700 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1lRAf7-00HHy7-4R; Tue, 30 Mar 2021 12:27:49 +0300 Date: Tue, 30 Mar 2021 12:27:49 +0300 From: Andy Shevchenko To: Qiheng Lin Cc: Arnd Bergmann , Greg Kroah-Hartman , Mihai Carabas , zhenwei pi , Paolo Bonzini , Joe Perches , Shile Zhang , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot Subject: Re: [PATCH -next] misc/pvpanic: fix return value check in pvpanic_pci_probe() Message-ID: References: <20210330013659.916-1-linqiheng@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330013659.916-1-linqiheng@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 09:36:59AM +0800, Qiheng Lin wrote: > In case of error, the function pci_iomap() returns NULL pointer > not ERR_PTR(). The IS_ERR() test in the return value check > should be replaced with NULL test. Error path there is broken completely, this is only one place you fix, but I suggest to switch to devm*, pcim* APIs instead, -- With Best Regards, Andy Shevchenko