Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [Question] Is there a race window between swapoff vs synchronous
 swap_readpage
To:     "Huang, Ying" <ying.huang@intel.com>
CC:     Linux-MM <linux-mm@kvack.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Matthew Wilcox <willy@infradead.org>,
        Yu Zhao <yuzhao@google.com>,
        "Shakeel Butt" <shakeelb@google.com>,
        Alex Shi <alex.shi@linux.alibaba.com>,
        "Minchan Kim" <minchan@kernel.org>
References: <364d7ce9-ccb7-fa04-7067-44a96be87060@huawei.com>
 <8735wdbdy4.fsf@yhuang6-desk1.ccr.corp.intel.com>
 <0cb765aa-1783-cd62-c4a4-b3fbc620532d@huawei.com>
 <87h7kt9ufw.fsf@yhuang6-desk1.ccr.corp.intel.com>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <7d2126a2-e67e-cadb-d732-77f8d54a2f0c@huawei.com>
Date:   Tue, 30 Mar 2021 19:21:54 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <87h7kt9ufw.fsf@yhuang6-desk1.ccr.corp.intel.com>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/3/30 11:44, Huang, Ying wrote:
> Miaohe Lin <linmiaohe@huawei.com> writes:
> 
>> On 2021/3/30 9:57, Huang, Ying wrote:
>>> Hi, Miaohe,
>>>
>>> Miaohe Lin <linmiaohe@huawei.com> writes:
>>>
>>>> Hi all,
>>>> I am investigating the swap code, and I found the below possible race window:
>>>>
>>>> CPU 1							CPU 2
>>>> -----							-----
>>>> do_swap_page
>>>>   skip swapcache case (synchronous swap_readpage)
>>>>     alloc_page_vma
>>>> 							swapoff
>>>> 							  release swap_file, bdev, or ...
>>>>       swap_readpage
>>>> 	check sis->flags is ok
>>>> 	  access swap_file, bdev or ...[oops!]
>>>> 							    si->flags = 0
>>>>
>>>> The swapcache case is ok because swapoff will wait on the page_lock of swapcache page.
>>>> Is this will really happen or Am I miss something ?
>>>> Any reply would be really grateful. Thanks! :)
>>>
>>> This appears possible.  Even for swapcache case, we can't guarantee the
>>
>> Many thanks for reply!
>>
>>> swap entry gotten from the page table is always valid too.  The
>>
>> The page table may change at any time. And we may thus do some useless work.
>> But the pte_same() check could handle these races correctly if these do not
>> result in oops.
>>
>>> underlying swap device can be swapped off at the same time.  So we use
>>> get/put_swap_device() for that.  Maybe we need similar stuff here.
>>
>> Using get/put_swap_device() to guard against swapoff for swap_readpage() sounds
>> really bad as swap_readpage() may take really long time. Also such race may not be
>> really hurtful because swapoff is usually done when system shutdown only.
>> I can not figure some simple and stable stuff out to fix this. Any suggestions or
>> could anyone help get rid of such race?
> 
> Some reference counting on the swap device can prevent swap device from
> swapping-off.  To reduce the performance overhead on the hot-path as
> much as possible, it appears we can use the percpu_ref.
> 

Sounds a good idea. Many thanks for your suggestion. :)

> Best Regards,
> Huang, Ying
> .
>