Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4321364pxf; Tue, 30 Mar 2021 05:10:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwL2M7HzUcJiiRs+OwyvjR2+viAEi2pQuHfGOFjZ8gMTipc8DmSLq9BRzZJDqj1hGxjOlNu X-Received: by 2002:a17:906:5383:: with SMTP id g3mr15445829ejo.185.1617106217618; Tue, 30 Mar 2021 05:10:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617106217; cv=none; d=google.com; s=arc-20160816; b=VQXuHSjgg6iSRXcAFLFs0BJNr7kNo5mX/f1MHlDHTpD2/2bpjZR5NuxHDhuH0Gdh9d 3ya5WW1m5sG7+hVfdwikw6EKD1QX3H8OJUAvd2zXAEszBjLtM7+c2DmrCXWYTrYoC5OO N1jhVOAFxesrn2WoRs0WPZ08zdy4IaMAzlhDsdyA1ltNvRuhnqtLMVBxAFM3FKchNI6W lSouBl1U3GOE3h7hLkUJ9xOUeKpgnsv1qr97rGfhOlT2IAUYfW9ioGqQ6/3/kaf/wv2C sSDTuBtLVC9ONtGCNShi3LmiTZzWCziJvBxrTZj9pnz09WSFoEbnhmBbE/g1qp9w6uTq A3SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7LMZ9F7lPaHwi9le/h++7n7vRCgfrM5V67L1bhRCi+Q=; b=xLPI+7+/HTvjXZ5yfPOX2fvbMJd+dg8TWF310qHlxlrUhjRGHmbDKkRnzbQhY+9c8C br4apSdA0Q106GGytO3P9oDpGBb+gmQ3MVcEtpQFhM42jipIZPdW5HtYSetBwLA9HFB0 bat0lOsg8gpvG4uMhJKAWCDnI9Zmg98hSwsgQKnXVBSdr+0bxdyH/OMVJvWM3VQO/Syw xwYajCUqvAHgD62TPqWdQtmjekpE0E4KiwXEzNumq3fwvhS/lFZfOZONEA559F5Siwa8 t6lbCEYjKXJ1xGoZ6Nnsd9UHESQLwRFBcshFWUNWNvWh4YBTRcn+JUJOnvVPaw6BJelx 5chw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jXuYOvZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dr18si14133092ejc.538.2021.03.30.05.09.54; Tue, 30 Mar 2021 05:10:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jXuYOvZJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231858AbhC3MIY (ORCPT + 99 others); Tue, 30 Mar 2021 08:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:36094 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231749AbhC3MIH (ORCPT ); Tue, 30 Mar 2021 08:08:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 593AF6195B; Tue, 30 Mar 2021 12:08:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617106086; bh=7LMZ9F7lPaHwi9le/h++7n7vRCgfrM5V67L1bhRCi+Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jXuYOvZJehXicC4lBBemhDOlN4/mbLo0CTtFE8Gq0yUORmuXpoM53CuJM0UJK9TMF EAm4Qg+Ay4P25jM0UIE6J7Cb0B2VYK/P+ykOuJoKlTDhYcMgJqgu5BQT5kLLRQL9xS qRTaGb5glQmunn9rVso+aSiU+0SrpvgNS20oI/aZcaGvrM23kRJnSrGhkl+677m9Wk Hk/zDiM6oPLWRWGJgW+sn7+MM1Y8x5UIA9oVrDTaQ6umZtStYdgJM4YjM6LbzyCtZ1 HkjI/GAXoHnjetRIWZjG0I7LWW9Vn8Q/poNBeOsqRluXSgC1jLwhrWhW1Q6DOljGlr Upqk/hFHtbQGw== Date: Tue, 30 Mar 2021 13:08:02 +0100 From: Will Deacon To: zhouchuangao Cc: Catalin Marinas , Masami Hiramatsu , Jean-Philippe Brucker , Andrew Morton , Qais Yousef , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] arm64/kernel/probes: Use BUG_ON instead of if condition followed by BUG. Message-ID: <20210330120801.GA5908@willie-the-truck> References: <1617105472-6081-1-git-send-email-zhouchuangao@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1617105472-6081-1-git-send-email-zhouchuangao@vivo.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 04:57:50AM -0700, zhouchuangao wrote: > It can be optimized at compile time. Hmm, I don't see it (and I also don't understand why we care). Do you have numbers showing that this is worthwhile? Will