Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 30 Mar 2021 15:34:24 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Steen Hegelund <steen.hegelund@microchip.com>
Cc:     Kishon Vijay Abraham I <kishon@ti.com>,
        Vinod Koul <vkoul@kernel.org>,
        linux-arm-kernel@lists.infradead.org,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Microchip UNG Driver List <UNGLinuxDriver@microchip.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH linux-next 1/1] phy: Sparx5 Eth SerDes: Use direct
 register operations
Message-ID: <YGMo4K4b9GIUIGu8@lunn.ch>
References: <20210329081438.558885-1-steen.hegelund@microchip.com>
 <20210329081438.558885-2-steen.hegelund@microchip.com>
 <YGIimz9UnVYWfcXH@lunn.ch>
 <2356027828f1fa424751e91e478ff4bc188e7f6d.camel@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2356027828f1fa424751e91e478ff4bc188e7f6d.camel@microchip.com>
Precedence: bulk

> > > +static int sparx5_sd25g28_apply_params(struct sparx5_serdes_macro *macro,
> > > +                                    struct sparx5_sd25g28_params *params)
> > >  {
> > > -     struct sparx5_serdes_regval item[] = {
> > 
> > Could you just add const here, and then it is no longer on the stack?
> > 
> >    Andrew
> 
> No it still counts against the stack even as a const structure.

I'm surprised. Maybe it needs static as well?

I'm just thinking you can get a much smaller patch if you don't need
to modify the table, just add additional qualifiers.

   Andrew