Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     "'richard.gong@linux.intel.com'" <richard.gong@linux.intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "mdf@kernel.org" <mdf@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Richard Gong <richard.gong@intel.com>
Subject: RE: [PATCH] firmware: stratix10-svc: extend SVC driver to get the
 firmware version
Thread-Topic: [PATCH] firmware: stratix10-svc: extend SVC driver to get the
 firmware version
Thread-Index: AQHXJW8QJprlVYn+I0GTi16JBVOwMqqck+Gw
Date:   Tue, 30 Mar 2021 14:19:02 +0000
Message-ID: <26176a0062114b9faa7c2c64c8ea3e64@AcuMS.aculab.com>
References: <1617114785-22211-1-git-send-email-richard.gong@linux.intel.com>
 <1617114785-22211-2-git-send-email-richard.gong@linux.intel.com>
In-Reply-To: <1617114785-22211-2-git-send-email-richard.gong@linux.intel.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: richard.gong@linux.intel.com
> Sent: 30 March 2021 15:33
> 
> Extend Intel service layer driver to get the firmware version running at
> FPGA device. Therefore FPGA manager driver, one of Intel service layer
> driver's client, can decide whether to handle the newly added bitstream
> authentication function based on the retrieved firmware version.

Using the version number to detect features is just plain wrong.

You should use something like a bitmap of supported features.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)