Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4420993pxf; Tue, 30 Mar 2021 07:26:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPo/59DNkIUmGovzEtdanIcJnyHbdJ2rs/hl4GSrr3ob2AtannV3nCx5TzUcEXcxRdQIwN X-Received: by 2002:a05:6402:b85:: with SMTP id cf5mr34656795edb.248.1617114411711; Tue, 30 Mar 2021 07:26:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617114411; cv=none; d=google.com; s=arc-20160816; b=RXVavZLdve75L1YoaAHaLKT+S/mp8GzjFAuTCXA43TWEEDHsAoqWWpDyx+TT0rV248 Ayznr6Hyf/ecLQ4Zxzop4QnRgq5Nmr6YVmmI87uNTnbVl7rQVPqOpghomJhcMy5wWUZT PlbGKgyMUrxlfo1Sp7uCODvAl7LPl/pntdSmFsdkJ4mbBWqs4Cq43T/UxBWQpNrzRyCM vukewQ83VE6VbZPnNQrZW/CnMZi4f1RHTeldQdgrvB23HzhiOKSkKT5ERNfyA2cEGLgw jsyCRim+r4iIvntAJFzfxyAmFJe3iB118i6uNzrBn4Q4maaQE4fanlVPRKacGRZaXx+D M9Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=6Gzpxf8xE0MSrOj7p7wtbLRmZsOsQD0Z12tbONnsyak=; b=j/Y7GSUG+dc09GPTQv0udHYjsLvinzeghyUOdbeLVXvSh/i1aBeHOnYambS0htJMAn o4Afs4hdjceJXmp/KLMe3S0m72sPugZVPS6raQXo6UB8Da964Cd5Tq3TeML+s3ezdlih +0zYr/IdUJFw2OwPZWalQzyXj5cOEI9YX8k/iRL3O9kejDxneX1LFyiqg1GxWr0A5VqQ c2F638wGEYEiml3bYphNwKsk1+u9YJEMMgj+hXUbVcwi7YSeLzHff+H2YiSPf2V5gU52 pu247xO+smudqM+ZL9/IPlAZ/IlMn0ECn2f+nV8U7lMoEvHSiX3jYTlcPhQrCcB+COU7 VFQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c25si14304447edw.293.2021.03.30.07.26.29; Tue, 30 Mar 2021 07:26:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232193AbhC3OXQ (ORCPT + 99 others); Tue, 30 Mar 2021 10:23:16 -0400 Received: from mga09.intel.com ([134.134.136.24]:15630 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbhC3OXE (ORCPT ); Tue, 30 Mar 2021 10:23:04 -0400 IronPort-SDR: nR9NUb2xROaGigpRtLMVCWocP4gFQkAs+ZJa/oOMWceOvnUrLLST15azimzX1uJsSGg8+b8l8k g3lOOSZei8rw== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="191874655" X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="191874655" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 07:23:00 -0700 IronPort-SDR: ghwn0ifiJw8J7fxvJoWtadsdpQs8QxU/11b4VnX/XZukEvV1bDWcHn9gPakWimqSBwy6MTEMIl 2J8X0rYuD8Cw== X-IronPort-AV: E=Sophos;i="5.81,291,1610438400"; d="scan'208";a="393626944" Received: from feifeich-mobl1.amr.corp.intel.com (HELO [10.212.41.240]) ([10.212.41.240]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2021 07:22:58 -0700 Subject: Re: [PATCH] ASoC: amd: Add support for ALC1015P codec in acp3x machine driver To: Vijendar Mukunda , broonie@kernel.org, alsa-devel@alsa-project.org Cc: shumingf@realtek.com, flove@realtek.com, kent_chen@realtek.com, jack.yu@realtek.com, Alexander.Deucher@amd.com, Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Ravulapati Vishnu vardhan rao , Arnd Bergmann , Akshu Agrawal , Kuninori Morimoto , Tzung-Bi Shih , open list References: <1617095628-8324-1-git-send-email-Vijendar.Mukunda@amd.com> From: Pierre-Louis Bossart Message-ID: <82817878-a30d-2b0c-07f8-48bcca3ebc80@linux.intel.com> Date: Tue, 30 Mar 2021 09:22:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1617095628-8324-1-git-send-email-Vijendar.Mukunda@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > static const struct acpi_device_id acp3x_audio_acpi_match[] = { > { "AMDI5682", (unsigned long)&acp3x_5682}, > { "AMDI1015", (unsigned long)&acp3x_1015}, > + { "AMDP1015", (unsigned long)&acp3x_1015p}, This isn't a valid ACPI ID. AMDP does not exist in https://uefi.org/acpi_id_list There was a similar issue with Intel platforms using this part, we had to use a different HID.