Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4458181pxf; Tue, 30 Mar 2021 08:17:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOljzZ4M9XuY650d4hxvuHp7uhPgwRvcgwQb0E3t6vUVPruXxt3Dm/j0Gia25i8LLmabqO X-Received: by 2002:a17:906:d157:: with SMTP id br23mr34878623ejb.192.1617117443698; Tue, 30 Mar 2021 08:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617117443; cv=none; d=google.com; s=arc-20160816; b=DrKJzg3mYV3xI5H08KVfOwrS3KBoJ4pwEFtNeOLQUZl/fpsBBBnonHKL2qwgrOCAcu WfgBjZvO9P1PiQ5kGCtBqXOKLKKQ0q46E7HJZHjbXmj+MJ5QFDz7lClYohVtccIhnBXW F3dvhN65KU6nuozVVuxacVX11kFmnNONg3kLoowomc1e71IU8FtPprlCWI1V/1oLSO/4 rGKNe4el92Hfdgo49wf5H6U7Jqu9vMnIAW5yPLQjq1SgqB1e1GyWnDEndi8XrXP8QYfT A/MZlnvLT6BW2PeivuSp+Jr12pUXQedjAOeuCzCpxnrkDZ5pGQr+QinIfb/lX3nAw/zV JdqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=PR903Xm9Ll2xHZ5LZVXdV8j9Ajyr0wheh7fL5h8RB+c=; b=s0znIKci85DCrruoetmzwBkPB3t/MIqyGaBdHD3yW7omdttr8PQviXxMpXd65vJj0q lDonSjCMXsk6u05HvPk+rEBrq03hRxI9wgatMQk9IEWeggI9q73iXTVi16/Ouj+SKJy5 0ysQicywkFOqSOJQtiGTmDW5y5WduNIH6zxTpQTI5GI9dxAKL9gQ1XUUuTlWfQ7fDR/F vqcU/mxSNXcMgJZbhVnwQPTuZc7jE8adbSRusmRNdNCgzwKDhwLyhqqvftcpStoH5Qd5 IeemfGIUKGvHcjL7lYF0N3lGPqRGAFoVqKOhf4BYoMNNzBWWSgImnX6KKEvbbunvbCx5 8NDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id nb32si16203962ejc.369.2021.03.30.08.17.00; Tue, 30 Mar 2021 08:17:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231935AbhC3PNR (ORCPT + 99 others); Tue, 30 Mar 2021 11:13:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:60046 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232261AbhC3PMA (ORCPT ); Tue, 30 Mar 2021 11:12:00 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C436B619D2; Tue, 30 Mar 2021 15:11:59 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lRG2A-004i6i-5O; Tue, 30 Mar 2021 16:11:58 +0100 From: Marc Zyngier To: Lorenzo Pieralisi , Bjorn Helgaas Cc: Frank Wunderlich , Thierry Reding , Thomas Gleixner , Rob Herring , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Michael Kelley , Wei Liu , Thierry Reding , Jonathan Hunter , Ryder Lee , Marek Vasut , Yoshihiro Shimoda , Michal Simek , Paul Walmsley , Bharat Kumar Gogada , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, kernel-team@android.com Subject: [PATCH v3 08/14] PCI/MSI: Kill msi_controller structure Date: Tue, 30 Mar 2021 16:11:39 +0100 Message-Id: <20210330151145.997953-9-maz@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210330151145.997953-1-maz@kernel.org> References: <20210330151145.997953-1-maz@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, bhelgaas@google.com, frank-w@public-files.de, treding@nvidia.com, tglx@linutronix.de, robh@kernel.org, will@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, mikelley@microsoft.com, wei.liu@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, ryder.lee@mediatek.com, marek.vasut+renesas@gmail.com, yoshihiro.shimoda.uh@renesas.com, michal.simek@xilinx.com, paul.walmsley@sifive.com, bharatku@xilinx.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org msi_controller had a good, long life as the abstraction for a driver providing MSIs to PCI devices. But it has been replaced in all drivers by the more expressive generic MSI framework. Farewell, struct msi_controller. Acked-by: Bjorn Helgaas Signed-off-by: Marc Zyngier --- include/linux/msi.h | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/include/linux/msi.h b/include/linux/msi.h index aef35fd1cf11..3f21e77b57b7 100644 --- a/include/linux/msi.h +++ b/include/linux/msi.h @@ -240,8 +240,7 @@ void pci_msi_unmask_irq(struct irq_data *data); /* * The arch hooks to setup up msi irqs. Default functions are implemented * as weak symbols so that they /can/ be overriden by architecture specific - * code if needed. These hooks must be enabled by the architecture or by - * drivers which depend on them via msi_controller based MSI handling. + * code if needed. These hooks can only be enabled by the architecture. * * If CONFIG_PCI_MSI_ARCH_FALLBACKS is not selected they are replaced by * stubs with warnings. @@ -272,19 +271,6 @@ static inline void arch_teardown_msi_irqs(struct pci_dev *dev) void arch_restore_msi_irqs(struct pci_dev *dev); void default_restore_msi_irqs(struct pci_dev *dev); -struct msi_controller { - struct module *owner; - struct device *dev; - struct device_node *of_node; - struct list_head list; - - int (*setup_irq)(struct msi_controller *chip, struct pci_dev *dev, - struct msi_desc *desc); - int (*setup_irqs)(struct msi_controller *chip, struct pci_dev *dev, - int nvec, int type); - void (*teardown_irq)(struct msi_controller *chip, unsigned int irq); -}; - #ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN #include -- 2.29.2