Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: Dmvo+4c49aUOqFiCN3HpsSVKoLMPtK8szbYydYV6VaiO+a9wUCRIqd/1mj7Nw8tnfc+vYkLy6s
 SY5GLJvSxFCA==
IronPort-SDR: LXRpHwKsdvxf9y/OfKTI7OsBQlAi1WChA9XmFTDca6XG5aS/2pjN1YnCcF7+teqPX5S9PCJHNp
 E7zrR5D0yI7g==
Subject: Re: [PATCH] firmware: stratix10-svc: extend SVC driver to get the
 firmware version
To:     David Laight <David.Laight@ACULAB.COM>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "mdf@kernel.org" <mdf@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Richard Gong <richard.gong@intel.com>
References: <1617114785-22211-1-git-send-email-richard.gong@linux.intel.com>
 <1617114785-22211-2-git-send-email-richard.gong@linux.intel.com>
 <26176a0062114b9faa7c2c64c8ea3e64@AcuMS.aculab.com>
From:   Richard Gong <richard.gong@linux.intel.com>
Message-ID: <16c40de5-b405-92b6-d08f-e395b9774e7e@linux.intel.com>
Date:   Tue, 30 Mar 2021 11:02:46 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <26176a0062114b9faa7c2c64c8ea3e64@AcuMS.aculab.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


Hi David,

On 3/30/21 9:19 AM, David Laight wrote:
> From: richard.gong@linux.intel.com
>> Sent: 30 March 2021 15:33
>>
>> Extend Intel service layer driver to get the firmware version running at
>> FPGA device. Therefore FPGA manager driver, one of Intel service layer
>> driver's client, can decide whether to handle the newly added bitstream
>> authentication function based on the retrieved firmware version.
> 
> Using the version number to detect features is just plain wrong.
> 
> You should use something like a bitmap of supported features.

Firmware, which runs at EL3, returns the version to Intel service layer 
driver in a 64-bit value at the register. Intel service layer driver 
runs at EL1.

Regards,
Richard

> 
> 	David
> 
> -
> Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
> Registration No: 1397386 (Wales)
>