Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4501831pxf; Tue, 30 Mar 2021 09:16:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdZaPlAjfytRvhk1B/Xj+0sDj4llpFvxyTfUNLGIrzPT5scDr7AZ7b8kdrCZNHOPUlGpoq X-Received: by 2002:a50:fa92:: with SMTP id w18mr34215653edr.172.1617120986257; Tue, 30 Mar 2021 09:16:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617120986; cv=none; d=google.com; s=arc-20160816; b=rukh4ir3/EKOdDldb1pT2hVO5rXnlbQEYP2fJ1y72IIMYgzg88egCiRb7rjKnSxRVn bXzayYcyo+spYCKILVAK5y7nFl084T5POUGAgpSjYgxrgZ8cPy2Ru8544oVZPwzhKS52 DNJhjOFCSWI39PdZfpyAzNDYK3VXncABAMjnWUqtjkyyCNIKy3v4XIJe9ZoiyuQvRYcC vV0Ikp1/ArJNj0epfvL60mBS5EC4CWXQTIsGTd0gWpZnV6YLriRr2orYWO7V5eMEmdqe QP5NPF9uHsdsHNs8hytmVp7YAuRG7PqeJDd/rTXQv8s16NK//EJQTt0VmVh07nF5hlWz 2QXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=C8dE4OXU10SnPyXITHR/58I6zNw62T8uKepw6EopNXA=; b=aVEKV/NE6wjxk7/5fGHIVSxkh2GvhWs+giEVCr1oL1FIL9fPXuNvfXn84SWZGHjiBN L9ZHl64eivxBLQNwTm6x67A/keMZ9UyO5VyaEwow0U6FXKyRzoANHozROIAyWcsKCR49 2Yn3m2/lpktCH1b+YOn4QguDK2KILZHN4AS4BpuToG0/3u9lsXgeu8IBEv3TAkzYwgRn +5eTWMCQMKmvZntlQNiWsVIH6RkDKCxVzRFutBlpoUBiaQkejZF3QaqM9lNTuQoTSElP q2ZsVdsjPNs9rSD/YZdiiamuRxCUXaYIOJT3wj/H0nv/Qm9qyol7Jul8WdHdoD2dtNqw Z9eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=hTYivTzS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s10si16309082edi.563.2021.03.30.09.16.02; Tue, 30 Mar 2021 09:16:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=hTYivTzS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232153AbhC3QMI (ORCPT + 99 others); Tue, 30 Mar 2021 12:12:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232141AbhC3QLn (ORCPT ); Tue, 30 Mar 2021 12:11:43 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEB28C061574 for ; Tue, 30 Mar 2021 09:11:42 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id y1so20470329ljm.10 for ; Tue, 30 Mar 2021 09:11:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=C8dE4OXU10SnPyXITHR/58I6zNw62T8uKepw6EopNXA=; b=hTYivTzSYfmEeO5VzKxrvnXqui4y3yPgMEEBDH7vKOanpymLhfmDI4XX46b63dB9Yc qLVchprkXlFscZmdBKGu9phv6uNnZraKGS+QuDb9kIJGWVGQMQ6pTWtfMalxtyZql8Va PJM768PLObXAsOL9BIQsjJYrJAX4qIjzNRo/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=C8dE4OXU10SnPyXITHR/58I6zNw62T8uKepw6EopNXA=; b=XXzuOfRkSla2KBxgrTldRQg7uaOgB3BbTl2cwlGWhUn9ZzqKtkQ2yl80+xLE0EfXWq wNv3cNkkZkeLohxnIolilx05nSCwr+yw9boYHI8vz0SOIBsjxlx5ps6j4NW0kRUPmoIo B5AVBhHH0trP3BCXJg4GojB0tbujp5pj4/6yfzoqk8GTYLqW8ZCLsR65GqXb7KLwNyPc 12YW/ngCVmoBJHunF1IobjGukzKjptOHRzn+ddSAOiwEm6r0+iKPgL/eicdIRnCQ5rki 58so22qNxTZsGZ36/RcN+j21RgpIrzD4MpOaQMIkJYwd1VCy9GJlNjVg2YBAHZZoQ1Wf +wiA== X-Gm-Message-State: AOAM530Snl511zOhlYzIjcq+uQXytLxWlG5tVE8Yf6UIsOly1J8QDVlH 00jPEaMk/v7pB/ZKINmRw7Et9ccMs54OXw== X-Received: by 2002:a2e:96d9:: with SMTP id d25mr14226155ljj.458.1617120701081; Tue, 30 Mar 2021 09:11:41 -0700 (PDT) Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com. [209.85.167.46]) by smtp.gmail.com with ESMTPSA id x17sm2216351lfg.164.2021.03.30.09.11.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Mar 2021 09:11:40 -0700 (PDT) Received: by mail-lf1-f46.google.com with SMTP id 12so14230187lfq.13 for ; Tue, 30 Mar 2021 09:11:39 -0700 (PDT) X-Received: by 2002:ac2:4250:: with SMTP id m16mr19284588lfl.40.1617120699723; Tue, 30 Mar 2021 09:11:39 -0700 (PDT) MIME-Version: 1.0 References: <05dc921e-da71-4e71-6132-736eccd35680@wanyeetech.com> In-Reply-To: <05dc921e-da71-4e71-6132-736eccd35680@wanyeetech.com> From: Linus Torvalds Date: Tue, 30 Mar 2021 09:11:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: exec error: BUG: Bad rss-counter To: Zhou Yanjie Cc: Ilya Lipnitskiy , "Eric W. Biederman" , Linux-MM , Linux Kernel Mailing List , linux-fsdevel , Kees Cook , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 29, 2021 at 9:56 PM Zhou Yanjie wro= te: > > On 2021/3/29 =E4=B8=8A=E5=8D=8810:48, Ilya Lipnitskiy wrote: > > > > Try: > > diff --git a/mm/memory.c b/mm/memory.c > > index c8e357627318..1fd753245369 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -166,7 +166,7 @@ static int __init init_zero_pfn(void) > > zero_pfn =3D page_to_pfn(ZERO_PAGE(0)); > > return 0; > > } > > -core_initcall(init_zero_pfn); > > +early_initcall(init_zero_pfn); > > It works, thanks! Looks good to me - init_zero_pfn() can be called early, because it depends on paging_init() will should have happened long before any initcalls in setup_arch(). Ilya, mind sending a signed-off version with a nice commit message, and I'll apply it. Linus