Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 3/5] i2c: add support for HiSilicon I2C controller
From:   Dmitry Osipenko <digetx@gmail.com>
To:     Yicong Yang <yangyicong@hisilicon.com>, wsa@kernel.org,
        andriy.shevchenko@linux.intel.com, linux-i2c@vger.kernel.org,
        Sergey.Semin@baikalelectronics.ru, linux-kernel@vger.kernel.org
Cc:     treding@nvidia.com, jarkko.nikula@linux.intel.com,
        rmk+kernel@armlinux.org.uk, song.bao.hua@hisilicon.com,
        john.garry@huawei.com, mika.westerberg@linux.intel.com,
        prime.zeng@huawei.com, linuxarm@huawei.com
References: <1617113966-40498-1-git-send-email-yangyicong@hisilicon.com>
 <1617113966-40498-4-git-send-email-yangyicong@hisilicon.com>
 <b761fa05-1bf9-ce4c-e2b5-f39b418f0da9@gmail.com>
Message-ID: <7efac5e2-aa1c-0575-0e9e-ca4eb659ed3f@gmail.com>
Date:   Tue, 30 Mar 2021 19:32:04 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <b761fa05-1bf9-ce4c-e2b5-f39b418f0da9@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

30.03.2021 19:24, Dmitry Osipenko пишет:
>> +struct hisi_i2c_controller {
>> +	struct i2c_adapter adapter;
>> +	void __iomem *iobase;
>> +	struct device *dev;
>> +	int irq;
>> +
>> +	/* Intermediates for recording the transfer process */
>> +	struct completion *completion;
>> +	struct i2c_msg *msgs;
>> +	int msg_num;
>> +	int msg_tx_idx;
>> +	int buf_tx_idx;
>> +	int msg_rx_idx;
>> +	int buf_rx_idx;
>> +	u16 tar_addr;
>> +	u32 xfer_err;
>> +
>> +	/* I2C bus configuration */
>> +	struct i2c_timings t;
>> +	u64 clk_rate_khz;
> Looks like the u64 is overkill here and it doesn't allow you to use
> COMPILE_TEST because 32bit arches can divide u64 only using the
> do_div(), please fix this.

I see now that the value isn't divided anywhere directly in the code, my
bad. Looks good then.