Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4565742pxf; Tue, 30 Mar 2021 10:50:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFDz/7d09zC6vj3vayadNXx5QQoJ3Y0b9Jt5B8GOf3ujLP4mdgOBqC5imz9PGGZr0kAvry X-Received: by 2002:a17:906:3395:: with SMTP id v21mr34664796eja.322.1617126616355; Tue, 30 Mar 2021 10:50:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617126616; cv=none; d=google.com; s=arc-20160816; b=vhQRnJTHeWQ4seAM0iG0iTZgSGezX6viq5fA0LCml0AKvvHu3smQ8ep2tZ8u2nto+I x/K20p1LcyeeHCgMgH6ZHCWz8WCXUpZhmWfGny2C55LQ9sS0LZcmIeNeOBZ2zqEj+k64 N20slr/jQ1TPF2TlBvVl7QyohLPWmKl2JS+rvTh69IWO6+NkBunJDx3wr7+hfkDl0aYO 4O0L8f3r6OqFHqXZ8d+2xXgf++UHusELwiXF0eRtq7d5SfbkJrYTb+i+h2ayzm9UzJjA w5o32Cz4VJj3KkgiAo0tZVzbInBgHVapDPux9AQeL1woinxdREfy+a5SrX578V364gLK q0fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=MKjq3QsULagZxXefgwhFaogNsuczJ0KPH/H8Ts7xm2g=; b=VCa1tYIgRR0QeP1pvfZc9e0JzjM0wtNSKmD+ELyOSmmXmOUyc64Iz48ksk8iqRzf/O 4pfE2pJEjjmqO7NefTIW4AM83VE4a65+EyjpVui1L8pj+RldB3SZa9mX7Ge2ayuo16cU sItuyxhY3uksvS0hie/CAlsvjkzrnNW2WqeyZcQTNWa6eAW3X+rShFtbIm+OytrV2+X0 JCzQOD4+LHP2DieE6aGEDI4BaGtvBYM128G2zz/GG0eTviMqdBD2Pe9qLMbYHDJyYKB6 sNZCc2ZfN8C4vyFKlPly5rqyqj4IRSFYmsakcWIrBCp2WeWFVpPLiBPXS3YDkw7RHwv1 w/1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si15588035edy.160.2021.03.30.10.49.49; Tue, 30 Mar 2021 10:50:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232236AbhC3Rsu (ORCPT + 99 others); Tue, 30 Mar 2021 13:48:50 -0400 Received: from verein.lst.de ([213.95.11.211]:59996 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbhC3Rsh (ORCPT ); Tue, 30 Mar 2021 13:48:37 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 1F87368B05; Tue, 30 Mar 2021 19:48:35 +0200 (CEST) Date: Tue, 30 Mar 2021 19:48:35 +0200 From: Christoph Hellwig To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH 1/3] MIPS: uaccess: Added __get/__put_kernel_nofault Message-ID: <20210330174835.GA15145@lst.de> References: <20210330172702.146909-1-tsbogend@alpha.franken.de> <20210330172702.146909-2-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330172702.146909-2-tsbogend@alpha.franken.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 07:26:58PM +0200, Thomas Bogendoerfer wrote: > Added __get/__put_kernel_nofault as preparation for removing > get/set_fs. For !CONFIG_EVA __get_user_common is simply defined to __get_kernel_common, which probably does the wrong thing here as it would allow access to user space addresses, won't it?