Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4566407pxf; Tue, 30 Mar 2021 10:51:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwcrTo5GtCr5ZZea7yQpBuqbDFH2CdH7GgWvZcjItw2PicND705UlB3aOC4PkH8VjBgGxpS X-Received: by 2002:a17:907:9e6:: with SMTP id ce6mr33708780ejc.207.1617126685264; Tue, 30 Mar 2021 10:51:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617126685; cv=none; d=google.com; s=arc-20160816; b=KilppMo+6tZsg5eAP1IMiVISJdS6WgLVOSX09tOvyWpDPHxDZe95u0ESIyZSEzerX+ +OH8YIs/wwrrrJzOjFUwaxVRTwfETIHTxTwtZLUeRHHbPWlKh7j5brZ7aTi4Ya3bDsiE ekM8Ej4kE7NIEFxmj0nwzjK/EZsGvdNP/CZfW9BKa7pS+vcZ/6NtVJ7pb4AOsckywbKv BOOK4wvy8Gz9Rw+Z6RZItjvtcsSDOCQq4KERRES9PG7WglZm6ObeWDbdw5eHFT0B83GW aycxlT6cywUQ1Qbc4VMGa+gQojvAo5OzzEbKXgfDCGZOOvc7f0gOpAhb39kv03JnBs5b 4Stg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=CQg4a8UQ6K8kfhATvlicjJfoY5p83oJ8TlciqdgQCGs=; b=oEhCLVZU6Qrnjq+QQ9LZKcjp4bdG3j4CJ8XoUozP6gpInz3/igjcIgqAHjYHvc2AJ7 i1+x1ZDBG3RkNcaUN0j0Fwz5H9SVkTET2YoMzOljmjQhQqxiDagZ+tNRL1vuEWmTyRrt NJGYS2EExwMZ+ZiZrUNNI4Tkn1uaBkz8qrWikq9znFp+7/UTnDd0DvBTbszsf3cA0NfK oLBgj84cLI76aFtF4oPVDjMZXd1LNPo/vUeq4TE1tThlWi8condFkk6oXO1JPsFmNi+6 wsOxn8KrphUzOE4ANFh4CkzwUe/3T6RET+SQ/OcCoROSLs8NK/27rXBEsv/tXmNXKVQr T12g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f7si11719262edd.239.2021.03.30.10.51.02; Tue, 30 Mar 2021 10:51:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232598AbhC3RuH (ORCPT + 99 others); Tue, 30 Mar 2021 13:50:07 -0400 Received: from verein.lst.de ([213.95.11.211]:60001 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232579AbhC3Rtp (ORCPT ); Tue, 30 Mar 2021 13:49:45 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id C6B2468B05; Tue, 30 Mar 2021 19:49:43 +0200 (CEST) Date: Tue, 30 Mar 2021 19:49:43 +0200 From: Christoph Hellwig To: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de Subject: Re: [PATCH 2/3] MIPS: uaccess: Remove get_fs/set_fs call sites Message-ID: <20210330174943.GB15145@lst.de> References: <20210330172702.146909-1-tsbogend@alpha.franken.de> <20210330172702.146909-3-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210330172702.146909-3-tsbogend@alpha.franken.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 30, 2021 at 07:26:59PM +0200, Thomas Bogendoerfer wrote: > +#define __get_data(x, ptr, u) \ > + (((u) == true) ? __get_udata((x), (ptr), sizeof(*(ptr))) : \ > + __get_kdata((x), (ptr), sizeof(*(ptr)))) > + I'm a little worried about exposing this in uaccess.h. Can you have local helpers insted, preferably strongly typed for their specific use cases?