Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4577282pxf; Tue, 30 Mar 2021 11:08:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwWu0BQ7E5aBGYB8NFec7c1/FO/v8+d2prLcTBMo/jCqkVJole1ZZLIMTGWMkbNZyz6m944 X-Received: by 2002:aa7:da46:: with SMTP id w6mr35614187eds.40.1617127683334; Tue, 30 Mar 2021 11:08:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617127683; cv=none; d=google.com; s=arc-20160816; b=EhyxAUj1ID8mfyi8VMBWPGO4k/wfkYTSLfL7K7waQTCPmGGoYrRy6wlEXRBkpVCBq7 IW8wKOKwxeWck6imfVSFUYgG6Ln82zLBlGEYxzaZ5AkvuJ4mVGRIyk5TMAKcejuOU6CK jT2PWl2d3XSmtJtkHUlg0UFzFTw379+Xr8Votl6oZF4FEM9DLmdpOGURGenxOnUmk40n 3mqM5uIDfBqVePwlg6twcR5f6oO3D+WwyoBUvbsZgSWkd8mtciEelNHnuoP+ussyC/ki FTPosXkrjrpnC+yfDlQaH6ekMkRTAGI0tU4wCxdJanwGMH7zjs0aTdxjmCZcN0+TOh2Z CXsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=DCGEHAzJrV8TqbrVal8s6ACJF5FQzaLRc2ecvWIp5uQ=; b=nw9fgUaY/x+0kDc0LdPAEioSgJaz79cDgn7R+oe8SOZqpehOjOvNqJf08Vc8t3lTm9 h5Zu7ROJoZcHiSDEXplHHazDwlAFAmPYolr/jDMWtFrnrYJbXwMl3f6xEnpmBdhdftIi oa8nNRGwJoZQblt5Q+D8KJBohpVcpQdrxnct7KY1zc5GYiXzy3CHag+FUpHXgKpiFOHn UwNvUn5n137Ii9efzUdRlzv66X725qzSUmiRb5zIKeOYRg7Euie9RnRcWJrXLuuwV7Dy YcSAiG48PIRwmK9QYbJFEFwCRBNE1UCEg+Mr0JkRYPWv504CbVx+V2dd+BwmCTRbSm1M qPHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=nTYQiqxt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kg8si16163192ejc.642.2021.03.30.11.07.40; Tue, 30 Mar 2021 11:08:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=nTYQiqxt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232645AbhC3SFJ (ORCPT + 99 others); Tue, 30 Mar 2021 14:05:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232455AbhC3SEn (ORCPT ); Tue, 30 Mar 2021 14:04:43 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DDA6C061574; Tue, 30 Mar 2021 11:04:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DCGEHAzJrV8TqbrVal8s6ACJF5FQzaLRc2ecvWIp5uQ=; b=nTYQiqxt4PueC98KnAfNM3/O38 dbsuOomyHP2AAlRvuWq0ux8fPHd8F9AS3elAPMNs18HIxYepjNZEn5zSbr98Hqgpc1geeVaP204zl 21VSZivSVIBjFQjuP9Q5dfdbiE02OgX3PfxknYyjJ5nTU1XeXX6KFan2NEs9KUTaHkJbSCDKrUv8o w7671ZbAJv3c9EdRAAhmW4H2S9m3c9VBPff0nUpyiYam9s558hgQKwh1z0gYhjmVeGie02WObM9wm /MpbSlDcjoomg4zbRudswmcl9sBaeRONWyNKtFGiY6VPHaWHAzfcuuYA9REhs8wkOgeoyyf9kGOaF k/pOWRSw==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lRIj2-003PGz-0F; Tue, 30 Mar 2021 18:04:28 +0000 Date: Tue, 30 Mar 2021 19:04:23 +0100 From: Christoph Hellwig To: Satya Tangirala Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Eric Biggers Subject: Re: [PATCH v2 1/8] block: introduce blk_ksm_is_empty() Message-ID: <20210330180423.GA811594@infradead.org> References: <20210325212609.492188-1-satyat@google.com> <20210325212609.492188-2-satyat@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210325212609.492188-2-satyat@google.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 25, 2021 at 09:26:02PM +0000, Satya Tangirala wrote: > This function checks if a given keyslot manager supports any encryption > mode/data unit size combination (and returns true if there is no such > supported combination). Helps clean up code a little. The name sounds a little strange to me, but the functionality looks ok. A kerneldoc comment might be useful to describe what it does so that we don't have to rely on the name alone.