Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arch: s390: Remove duplicate struct ccw1 declaration
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Julian Wiedmann <jwi@linux.ibm.com>,
        Alexandra Winter <wintera@linux.ibm.com>,
        Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
        linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     kael_w@yeah.net
References: <20210330105638.2742356-1-wanjiabing@vivo.com>
From:   Vineeth Vijayan <vneethv@linux.ibm.com>
Message-ID: <23819124-7c34-4c57-5e76-e5b3d2750a73@linux.ibm.com>
Date:   Tue, 30 Mar 2021 20:39:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210330105638.2742356-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Thank you for the patch.
Acked-by: Vineeth Vijayan <vneethv@linux.ibm.com>
Heiko/Vasily will pick this up and will be part of the s390-tree patchset.

On 3/30/21 12:56 PM, Wan Jiabing wrote:
> struct ccw1 is declared twice. One has been declared
> at 21st line. Remove the duplicate.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>   arch/s390/include/asm/ccwdev.h | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/s390/include/asm/ccwdev.h b/arch/s390/include/asm/ccwdev.h
> index 778247bb1d61..d4e90f2ba77e 100644
> --- a/arch/s390/include/asm/ccwdev.h
> +++ b/arch/s390/include/asm/ccwdev.h
> @@ -152,9 +152,6 @@ extern struct ccw_device *get_ccwdev_by_busid(struct ccw_driver *cdrv,
>    * when new devices for its type pop up */
>   extern int  ccw_driver_register   (struct ccw_driver *driver);
>   extern void ccw_driver_unregister (struct ccw_driver *driver);
> -
> -struct ccw1;
> -
>   extern int ccw_device_set_options_mask(struct ccw_device *, unsigned long);
>   extern int ccw_device_set_options(struct ccw_device *, unsigned long);
>   extern void ccw_device_clear_options(struct ccw_device *, unsigned long);