Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4653388pxf; Tue, 30 Mar 2021 13:22:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzq/VJIcGItZQ+9/mF4BIp+vhH0YKT7qD40ekD7TPIukTOzkASnPkDyg9IDq1+l8Cj+rmiQ X-Received: by 2002:aa7:c815:: with SMTP id a21mr35827900edt.38.1617135745634; Tue, 30 Mar 2021 13:22:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617135745; cv=none; d=google.com; s=arc-20160816; b=0LFNkc8/9iW+fC8MT2gJl0nr4V+aARlZMiX8P2jMULJa58dGJlOiS9TGAl7YeutKuz gM8YyVeW9hHVeOv0boY8LBtTtQGRd4DpSm5zskXnAwefyA0V0O9821NQRQYRwA3xAyvx hOKONBA5/UAr/wGmsAcucTOkw2SG/lqR2B4/oKoBf5gj6KyG/u1mrEf7hmq9ppyZHdmu aE3GI9Nn44zz/SS/kGdhHbtzTm8rOfRGU/rhTae5GLaDqlYMJqaMxXESEvfudJrTfeSe 9NKRkUzmakVESfP2aNsmYHz48b5Qot2MskWyATik+F5nDonBoNGkH3VPRwKUWAyyt+3l AB6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=m9wAHeccPN//FYXiJGZoUIzMn/z6txWih8ssTkCV1qg=; b=VHUivQZwGM09LoiqfAWIVrzzBAkXttTAdH9ZSjxpJidhcpMTw1tvgR8FKTQ7CWSaxz HWjyjfRbBjEWJmRQ/H1c9yOdcNnMhoBW7FW8GkPwpkFIyu12SpCPT5VgO6BS8hxQZt+Z ilgP1PnSgHeuGq0pZcBaeOqWCS4870QNYdhzR3aDTBZz2LL2jwV9emRCoiAfMj8m488t NlvCTOMkn+WF1K+tzAuMTPWnha6sh4Pb0VpQCQJuDKzI0YnwwVtJc2eaqbzkf9pXyHRF xw9eYpimEBjPK6zR+FbJWsVBmvdF9amMCj3zubmoIlTLiTqu9BpQC5OB0WaRmRQe7GF+ 2Ubw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z5Grzael; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq23si15361902ejb.498.2021.03.30.13.22.01; Tue, 30 Mar 2021 13:22:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Z5Grzael; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232001AbhC3UU2 (ORCPT + 99 others); Tue, 30 Mar 2021 16:20:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:47984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229940AbhC3UUJ (ORCPT ); Tue, 30 Mar 2021 16:20:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPS id E689461883; Tue, 30 Mar 2021 20:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617135608; bh=8Rr5rht8BU1NXR5spILZKqkILrtTO6kantTYozrDWpM=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Z5GrzaelxYfTd8XrUty7GXZmLFuF0fKjPQHtsebXLfmDt0ovOMi8jY51a+8Xe5SXG esmPI1mqKA8bC5Ad0YNAoeeSgnEh8VMZPmUqqlvd1AwtUaPffwCYDUVw4ZsoGwwUM5 U2UN8KoHet8LwUIiXO1+NS7FkRzdj0msp6snqghtltnNQpk4xe80j8vjadumSU/SiI a1ySUFMChD3IBCE0HGNVKuXEPTUdJRDLyyIJoZ4oSuT9fFLPBXSNjvVSu10A6CuGAj wdvA3qME5bH0Pg5v/JwuVQVGOJuvQj1KKGqM+bzzfjT0PyMdXAitO3/KjHPcBoN7E4 c54uAPwHAnXmg== Received: from pdx-korg-docbuild-2.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by pdx-korg-docbuild-2.ci.codeaurora.org (Postfix) with ESMTP id D767460A5B; Tue, 30 Mar 2021 20:20:08 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] net/ncsi: Avoid channel_monitor hrtimer deadlock From: patchwork-bot+netdevbpf@kernel.org Message-Id: <161713560887.2790.12767006562896839365.git-patchwork-notify@kernel.org> Date: Tue, 30 Mar 2021 20:20:08 +0000 References: <20210329152039.15189-1-eajames@linux.ibm.com> In-Reply-To: <20210329152039.15189-1-eajames@linux.ibm.com> To: Eddie James Cc: sam@mendozajonas.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, miltonm@us.ibm.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net.git (refs/heads/master): On Mon, 29 Mar 2021 10:20:39 -0500 you wrote: > From: Milton Miller > > Calling ncsi_stop_channel_monitor from channel_monitor is a guaranteed > deadlock on SMP because stop calls del_timer_sync on the timer that > inoked channel_monitor as its timer function. > > Recognise the inherent race of marking the monitor disabled before > deleting the timer by just returning if enable was cleared. After > a timeout (the default case -- reset to START when response received) > just mark the monitor.enabled false. > > [...] Here is the summary with links: - net/ncsi: Avoid channel_monitor hrtimer deadlock https://git.kernel.org/netdev/net/c/03cb4d05b4ea You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html