Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4764496pxf; Tue, 30 Mar 2021 17:06:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHDCMQXOyaf8qzJNps5X67tfya8zYMil5m6VWgNOKWWY25tyFs2Jhe1wiq6dTM5vmwygEQ X-Received: by 2002:aa7:cf16:: with SMTP id a22mr453591edy.288.1617149215671; Tue, 30 Mar 2021 17:06:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617149215; cv=none; d=google.com; s=arc-20160816; b=QX9nUQhzstx4Pc6Hi2MMdiHYm2AKdGMqB/t4EA+4EZ73UbfOqHfnZATYoDb7PxkOy/ Q7iQcaPr/6t8aY/ouKqULwAJ/jB3O9RLqRiz16MAfpg7xCc9BsBb1NNRF7RObFh4CoFC HCVJkQCNsgWEXA7r0VT1NTCQhviQZVhqCCgO1kUvJF7AtVzabFrPU58I7pZ+mgusTWAj dQ7I1a8KLJXjhlXbB0+HukSoSVIbVxWuvEBz+KTvCvJi8AE2HW26/Oh9MDBX0LXcajwQ xDWqS8z6kItuvsePK8k7hrQazMJCDnt5uxN/DCmxU2brOW5tXvgiB+Ggws45epJzot33 aEEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=vmRZ10/1iQ18gfm/WSR9qlb6d+lZPLMa5279a49hrqk=; b=lT9E2uLPi10ytskEEBZCUg86MJ4tYJ0Z76jYqmU3BkHZOeZFvDNxb/snvFgibz92Yw grlv1ODtNsNCq72ywLvWjCbCF47hS2qlur46BbGfVxdOsnqgh6Ijfi4BILPqZJTor8UG 5zXRGQWdZ/K5DIWszHwX6ztmbnTtiRsxatCym433jJdTfG285u+IK/RVe54nhMHiHut+ W+HqfvYfD1hQIIaduZkTxXBTpn3x3gWbGNxqtBAGYMMyOUeG9bdxCS+kncTQQE66Mj13 9C5wBKrCpPqW0DBAs0uN653UozwNr5QsN2c9njkCcQAC7o/zDm+znZAQTjvCKmxZSzcq hf1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si411582edr.505.2021.03.30.17.06.29; Tue, 30 Mar 2021 17:06:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232126AbhCaAC4 (ORCPT + 99 others); Tue, 30 Mar 2021 20:02:56 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50554 "EHLO mail.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232367AbhCaACe (ORCPT ); Tue, 30 Mar 2021 20:02:34 -0400 Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 16F344D25BD13; Tue, 30 Mar 2021 17:02:33 -0700 (PDT) Date: Tue, 30 Mar 2021 17:02:28 -0700 (PDT) Message-Id: <20210330.170228.191449180243560631.davem@davemloft.net> To: lyl2019@mail.ustc.edu.cn Cc: santosh.shilimkar@oracle.com, kuba@kernel.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/rds: Fix a use after free in rds_message_map_pages From: David Miller In-Reply-To: <20210330101602.22505-1-lyl2019@mail.ustc.edu.cn> References: <20210330101602.22505-1-lyl2019@mail.ustc.edu.cn> X-Mailer: Mew version 6.8 on Emacs 27.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Tue, 30 Mar 2021 17:02:33 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Lv Yunlong Date: Tue, 30 Mar 2021 03:16:02 -0700 > @@ -348,7 +348,7 @@ struct rds_message *rds_message_map_pages(unsigned long *page_addrs, unsigned in > rm->data.op_sg = rds_message_alloc_sgs(rm, num_sgs); > if (IS_ERR(rm->data.op_sg)) { > rds_message_put(rm); > - return ERR_CAST(rm->data.op_sg); > + return ERR_PTR(-ENOMEM); > } > > for (i = 0; i < rm->data.op_nents; ++i) { Maybe instead do: int err = ERR_CAST(rm->data.op_sg); rds_message_put(rm); return err; Then if rds_message_alloc_sgs() starts to return other errors, they will propagate. Thank you.