Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp29955pxf; Tue, 30 Mar 2021 18:12:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzsKbt/EjYF5PlsoUSD+FOSkRuQOUpNSglCKSNjEYglhlJq3nZJ2O15YeGamofVP88Akw4W X-Received: by 2002:a17:906:39a:: with SMTP id b26mr943587eja.158.1617153137950; Tue, 30 Mar 2021 18:12:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617153137; cv=none; d=google.com; s=arc-20160816; b=jiTVBmZP3d66AfmbEqjrNT/DfwgmmetYAjfEZurmWUXiNdu0HXZrfODgYLRvO0Sw8j CDMT4IOCNRALt3uU9y84xop5U2HMfCmALtXBSTE+anIRDIrfNZHnYR4GB6F0p54Xo1Sz u8bAtTPNdYfrQFPvGa2tB/SQAsVc0uN64D1tYLxc963rkjlVC0z9Nqtz8Gu5fnNCm4Kr nI3Q3pXywlV4dmaDnuO9YjGx6TEaTKUQFl0nqVTzA/sOqkXVJfm/KpmDpOgrDqhbtXvA XVeeqCda4e3q8l18+knTMYQIVlTaMjCbRCRMUebp3Eg+MwEhTipNPxRhF7Y+29cVHiTq SwFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from; bh=aGP8+yuvpkCSq6wcADuakbpYrhTxu40e7s72ekjv8d0=; b=wkYakayi0gL6Ww4XLfkHs7ogpVNnqlSqeIDPBc1P0WxF9hU7NcFAJnRcaFTiRSfqOY JokLlT1KJickB6tMz++HR3gaTu+k0t6sub3P2R34mcWKsVB5+2C2UUvh1DqeVlLuma+Q CEpqN3TdGfuUTeKNcdO/GW1z3MwBcF2TtV5zJBYQiB8GdniiEDeYlBxrVa3TB+NNDaP8 /jN0l1sQR4SbSW/G44SKPD38i0JJhktNXrlRmuj5LQ0TFkIQoJbVuDma2kV/fIDJeeoe NaYc0y32j3iiayhsI9QMOXqM0riKFziKoHszz7TrKZ2TwZ7EDFsHlMZD4WZ4EHDdfUZL iGyA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq24si454808ejc.24.2021.03.30.18.11.55; Tue, 30 Mar 2021 18:12:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233282AbhCaBKj (ORCPT + 99 others); Tue, 30 Mar 2021 21:10:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233077AbhCaBKP (ORCPT ); Tue, 30 Mar 2021 21:10:15 -0400 Received: from ozlabs.org (bilbo.ozlabs.org [IPv6:2401:3900:2:1::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 586ADC061574 for ; Tue, 30 Mar 2021 18:10:15 -0700 (PDT) Received: by ozlabs.org (Postfix, from userid 1034) id 4F97XN0ST7z9sXb; Wed, 31 Mar 2021 12:10:11 +1100 (AEDT) From: Michael Ellerman To: Michael Ellerman , Paul Mackerras , Benjamin Herrenschmidt , Christophe Leroy Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org In-Reply-To: <8038392f38d81f2ad169347efac29146f553b238.1615819955.git.christophe.leroy@csgroup.eu> References: <8038392f38d81f2ad169347efac29146f553b238.1615819955.git.christophe.leroy@csgroup.eu> Subject: Re: [PATCH] powerpc/mm: Remove unneeded #ifdef CONFIG_PPC_MEM_KEYS Message-Id: <161715297876.226945.6700622335291233560.b4-ty@ellerman.id.au> Date: Wed, 31 Mar 2021 12:09:38 +1100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 15 Mar 2021 14:52:51 +0000 (UTC), Christophe Leroy wrote: > In fault.c, #ifdef CONFIG_PPC_MEM_KEYS is not needed because all > functions are always defined, and arch_vma_access_permitted() > always returns true when CONFIG_PPC_MEM_KEYS is not defined so > access_pkey_error() will return false so bad_access_pkey() > will never be called. > > Include linux/pkeys.h to get a definition of vma_pkeys() for > bad_access_pkey(). Applied to powerpc/next. [1/1] powerpc/mm: Remove unneeded #ifdef CONFIG_PPC_MEM_KEYS https://git.kernel.org/powerpc/c/98c26a72751ecb2ed247cdfd6cb2385f37195707 cheers