Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp72387pxf; Tue, 30 Mar 2021 19:52:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsyV6AingjdxdVjm2sN69eqCdXlKQwIkjkyu+c4Vp5RNFLoeQ/Yd8FkBH8Tbhbz9RpX8jS X-Received: by 2002:a17:906:d157:: with SMTP id br23mr1251372ejb.192.1617159154783; Tue, 30 Mar 2021 19:52:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617159154; cv=none; d=google.com; s=arc-20160816; b=sF2J7DGAwyzOQPoYK2H8vabCU1arzaqu17gMJsGufbGWlMj8nQLACHoHeybtRVyrZ1 feuneRHlMqPdZlqXC8Ikvby6mG3FuzQzJJnRZeaJ25Sf6tsnszDJw944DfnhK9JoCsNM O0O18WE9xWd65SMxjz/wCmqNw/3qOZU2DYS6mw4uRka9238OItnaz5cWSSxQgKJ57XdW TIHGh3JfSeCzYnRhCuvIQl007sISRiAwP8hY/Jj5ANnE4HpuyD1pt4tHBl+O96IfsIa1 GN6I5xTdP+qCfQVCjM2EQ0RhdsBecI8zwlbNyJEoWqb1BimKLaBYsiY42Q1C/cWcvEbx Kqaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=KuuVs4AA9FyK18CvDc5roKKb7LROBkTECv7Ce5PKhZ4=; b=OyoKmI/z+NxdZpqQN0DTk5eFFUk/6+EITlradXDeVkt+MBZp+xLCa+Q4hdJ8BEWPOc X96ihc4x+5bFpZwXxAf7jzyI6LXasdGjD6AW2gx2JYmKqeEtu0QPy3CPYyln3F2EXCkd v6Glb9Wn21p5Xj1zCDb12HpsVonz/d25ITqr9+3wzTyTlt/wq5BpT26PRgtVKCBPnaVc 88pmDp+++DhAnNDkY8jM3uTaGyC6/m310M8bozB88O7msV5UktyXa8Cmu7NKBMN44n0l IgZPcd/juPBYm1+WFeJiLWnD1/q6fv7kIEcgFlRFE5f/xk/Qbe9PYgTgBsuTvcihrG1p VKFg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JyYkbrwx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qh28si533996ejb.580.2021.03.30.19.52.11; Tue, 30 Mar 2021 19:52:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=JyYkbrwx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233360AbhCaCtI (ORCPT + 99 others); Tue, 30 Mar 2021 22:49:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:33508 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230160AbhCaCsl (ORCPT ); Tue, 30 Mar 2021 22:48:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BDA0C619D3; Wed, 31 Mar 2021 02:48:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1617158921; bh=a5Zjyrdx2349NQa+T6hwW+EkY6zzo08x0wON8Albck0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JyYkbrwxvlLCuuAPfmHI6bRXSEeJdXHgcFsylOTFBa2xy0MUCh5nWZ4Ow9nlrd3/V H9w4cS5Xfu9ROLY+OiwxN4iMV/fdt5bWHSCVkoZyD/CovlkHgQ6CCnR1ewMhCLRlhU 5qUzg5xAcFIne/G5vjEMNNd3SgFOlhGqboSpZN2/JFUnx9A2KIKIv7j+l0TL5foCId Q3Coyiv4AtYNDcj6tLcm2xsIhcL1fkjyD2B9+mPQz+6WrUKajpEpfNbn2M12aRpDPG XnKJSYbPMqRXCWeOQYUhRRGmWPeFyrk1s5K7Zjnx2J/62L8mjWeQDizTP2ncVIE6z6 wjblHUoZ+kFgQ== Date: Tue, 30 Mar 2021 19:48:39 -0700 From: Jakub Kicinski To: Ong Boon Leong Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Maxime Coquelin , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH net-next v2 5/6] net: stmmac: Add support for XDP_TX action Message-ID: <20210330194839.0b8596f2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210330024949.14010-6-boon.leong.ong@intel.com> References: <20210330024949.14010-1-boon.leong.ong@intel.com> <20210330024949.14010-6-boon.leong.ong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Mar 2021 10:49:48 +0800 Ong Boon Leong wrote: > + __netif_tx_lock(nq, cpu); > + res = stmmac_xdp_xmit_xdpf(priv, queue, xdpf); > + if (res == STMMAC_XDP_TX) { > + stmmac_flush_tx_descriptors(priv, queue); > + stmmac_tx_timer_arm(priv, queue); > + } > + __netif_tx_unlock(nq); You may want to update nq->trans_start, see commit ec107e775d843