Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 31 Mar 2021 05:54:06 +0300
From:   Jarkko Sakkinen <jarkko@kernel.org>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
        trivial@kernel.org
Subject: Re: [PATCH] IMA: Fix error in comment
Message-ID: <YGPkTuoDhupnzuJB@kernel.org>
References: <20210330060845.18422-1-ribalda@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210330060845.18422-1-ribalda@chromium.org>
Precedence: bulk

On Tue, Mar 30, 2021 at 08:08:45AM +0200, Ricardo Ribalda wrote:
> ima_file_mprotect does not return EACCES but EPERM.
> 
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>


Acked-by: Jarkko Sakkinen <jarkko@kernel.org>

/Jarkko

> ---
>  security/integrity/ima/ima_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/security/integrity/ima/ima_main.c b/security/integrity/ima/ima_main.c
> index 9ef748ea829f..716ea29cf897 100644
> --- a/security/integrity/ima/ima_main.c
> +++ b/security/integrity/ima/ima_main.c
> @@ -409,7 +409,7 @@ int ima_file_mmap(struct file *file, unsigned long prot)
>   * this point.  Eliminate this integrity gap by denying the mprotect
>   * PROT_EXECUTE change, if an mmap appraise policy rule exists.
>   *
> - * On mprotect change success, return 0.  On failure, return -EACESS.
> + * On mprotect change success, return 0.  On failure, return -EPERM.
>   */
>  int ima_file_mprotect(struct vm_area_struct *vma, unsigned long prot)
>  {
> -- 
> 2.31.0.291.g576ba9dcdaf-goog
> 
>