Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: PfZ6ebAWMII3s2EChd/xHkbGjR9QNpOlR0o+gHyV0kyK9mUsAeRc5a+VBngGi6B+Eq+mIhwFNy
 eYbZII1VCL8Lquc4whrHWAIXWM+QQqiSee+yrH/cA4Cl9OGddDP6P8UbjH3hIRY8+XON931xum
 l6QgJ/Z6rpwlta9cx03I1+2gIVr34zgBdJpKIqxpWDDwf1fP8R+/A65kOUvSz3JxBfwE4s/Z9Z
 JOpt/yK69U7sLI/X4t0TF4FVUTy+Wsf2lISk9cAd1vsQuPSOij1WEJJ1NqJ8Fk3lUqCzO2Cmf9
 n/E=
From:   Can Guo <cang@codeaurora.org>
To:     asutoshd@codeaurora.org, nguyenb@codeaurora.org,
        hongwus@codeaurora.org, linux-scsi@vger.kernel.org,
        kernel-team@android.com, cang@codeaurora.org
Cc:     Alim Akhtar <alim.akhtar@samsung.com>,
        Avri Altman <avri.altman@wdc.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v4 1/2] scsi: ufs: Fix task management request completion timeout
Date:   Tue, 30 Mar 2021 21:50:34 -0700
Message-Id: <1617166236-39908-2-git-send-email-cang@codeaurora.org>
In-Reply-To: <1617166236-39908-1-git-send-email-cang@codeaurora.org>
References: <1617166236-39908-1-git-send-email-cang@codeaurora.org>
Precedence: bulk

ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn = ufshcd_compl_tm()),
but since blk_mq_tagset_busy_iter() only iterates over all reserved tags
and requests which are not in IDLE state, ufshcd_compl_tm() never gets a
chance to run. Thus, TMR always ends up with completion timeout. Fix it by
calling blk_mq_start_request() in  __ufshcd_issue_tm_cmd().

Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to allocate and free TMFs")

Signed-off-by: Can Guo <cang@codeaurora.org>
---
 drivers/scsi/ufs/ufshcd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b49555fa..d4f8cb2 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6464,6 +6464,7 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba,
 
 	spin_lock_irqsave(host->host_lock, flags);
 	task_tag = hba->nutrs + free_slot;
+	blk_mq_start_request(req);
 
 	treq->req_header.dword_0 |= cpu_to_be32(task_tag);
 
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.