Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1617085972-6094-1-git-send-email-shengjiu.wang@nxp.com> <20210330150521.GD4976@sirena.org.uk>
In-Reply-To: <20210330150521.GD4976@sirena.org.uk>
From:   Shengjiu Wang <shengjiu.wang@gmail.com>
Date:   Wed, 31 Mar 2021 13:45:28 +0800
Message-ID: <CAA+D8AP-LC=zmd+5uMG_Q371pg3RrQPrJkURCx4=f0juUpHrFA@mail.gmail.com>
Subject: Re: [PATCH 1/2] ASoC: ak5558: Add support for ak5552
To:     Mark Brown <broonie@kernel.org>
Cc:     Shengjiu Wang <shengjiu.wang@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, alsa-devel@alsa-project.org,
        Liam Girdwood <lgirdwood@gmail.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Takashi Iwai <tiwai@suse.com>, Rob Herring <robh+dt@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Mar 30, 2021 at 11:06 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, Mar 30, 2021 at 02:32:51PM +0800, Shengjiu Wang wrote:
>
> > +static const struct snd_kcontrol_new ak5552_snd_controls[] = {
> > +     SOC_ENUM("AK5552 Monaural Mode", ak5552_mono_enum[0]),
> > +     SOC_ENUM("AK5552 Digital Filter", ak5558_adcset_enum[0]),
> > +};
>
> It's a bit weird to have AK5552 in the control name - any reason for
> that?

Just to distinguish ak5558 and ak5552, but I think it can be removed.
will update it in v2

Best regards
wang shengjiu