Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: GopJlAZPpiXRndsZX4us5CKMdUIsGFYGpQRzEF25T1/LIamb2ZcfhXpg+Ak1ObFHBEN2Z8eAwI
 R27d7SWn3OnoCiJMx3sf3mVZN6plSfykqGyPMMiNyHBV3PvJs+zdt4X/+xPLpGIt9BSVOuIlt5
 AkhFtwuiAA9Lzx/4X70YoZYI0CSFW//YfIx8yk2jCgSFUVKAbc5rqoo2Owo6UUnTLoFU3x7SQy
 QXvqbhQ28LoXOFnQq6jbwqnvGGVbG8/B9LluxtrOSsus2aIQwazVrPw+G35bR9fPIYSvIZXGtd
 0gg=
IronPort-SDR: L1NfyXW0ylGyGsi454b7FxDPhlUpVWZkm+qXydBnq0hj7v+Ce1OkcKCLfoEo/c0pR/7tNzKNld
 OSUFur80cP+xfME+5bq+PwfIizh+Saa9xqghkqqy5ptgQpZgdleTN4yfXLUU5bbi0tjcw3ymKJ
 ZM+YPGjAOwm4I6yveQ3Pvpqqu6BWRFwaLBEHVdTSJI4pjNYHVRjvRo1QftIwBFVaW5obOY9TKp
 A4rVa9c8Igpq5qnPVZ/RY5TTcLTYxpWlyJN0k67DeVOVjhWHwJPND4loAwwUolXGJR2HmYafBS
 1KvSkqTNHZMMYWlA9pQ9NHZn
IronPort-SDR: +PspDZ1oVg43ApFFOTzQxICU2vVitrl+4tkX8AsE1qBD86w59fiXwX7X216rN6aKf+7QNeZkEo
 Y7v3sdhWGaDgETgnDngH0LVgm9b+AQL5Zg6XnBgMW+YmMnz8qFL8+2ROTAB8vERlOBnBoryOLW
 LKsCe+DPBRHo4a6yxaPAiO2/EyFn+NTUdsMQcCr2vScxzVdE+xavhjSdBFO8GPJSkaqNynLIK0
 u+Vr78v2VPHseA9J3PAu82jF2OCUQ99g19S6n5QVMNAGYntbSD8ZGjV/Y/M9oEZOxHu1utOvCW
 cj8=
WDCIronportException: Internal
From:   Avri Altman <avri.altman@wdc.com>
To:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        alim.akhtar@samsung.com, asutoshd@codeaurora.org,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <avi.shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>, cang@codeaurora.org,
        stanley.chu@mediatek.com, Avri Altman <avri.altman@wdc.com>
Subject: [PATCH v7 05/11] scsi: ufshpb: Make eviction depends on region's reads
Date:   Wed, 31 Mar 2021 10:39:46 +0300
Message-Id: <20210331073952.102162-6-avri.altman@wdc.com>
In-Reply-To: <20210331073952.102162-1-avri.altman@wdc.com>
References: <20210331073952.102162-1-avri.altman@wdc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

In host mode, eviction is considered an extreme measure.
verify that the entering region has enough reads, and the exiting
region has much less reads.

Signed-off-by: Avri Altman <avri.altman@wdc.com>
---
 drivers/scsi/ufs/ufshpb.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshpb.c b/drivers/scsi/ufs/ufshpb.c
index 3ab66421dc00..aefb6dc160ee 100644
--- a/drivers/scsi/ufs/ufshpb.c
+++ b/drivers/scsi/ufs/ufshpb.c
@@ -17,6 +17,7 @@
 #include "../sd.h"
 
 #define ACTIVATION_THRESHOLD 8 /* 8 IOs */
+#define EVICTION_THRESHOLD (ACTIVATION_THRESHOLD << 5) /* 256 IOs */
 
 /* memory management */
 static struct kmem_cache *ufshpb_mctx_cache;
@@ -1057,6 +1058,13 @@ static struct ufshpb_region *ufshpb_victim_lru_info(struct ufshpb_lu *hpb)
 		if (ufshpb_check_srgns_issue_state(hpb, rgn))
 			continue;
 
+		/*
+		 * in host control mode, verify that the exiting region
+		 * has less reads
+		 */
+		if (hpb->is_hcm && rgn->reads > (EVICTION_THRESHOLD >> 1))
+			continue;
+
 		victim_rgn = rgn;
 		break;
 	}
@@ -1229,7 +1237,7 @@ static int ufshpb_issue_map_req(struct ufshpb_lu *hpb,
 
 static int ufshpb_add_region(struct ufshpb_lu *hpb, struct ufshpb_region *rgn)
 {
-	struct ufshpb_region *victim_rgn;
+	struct ufshpb_region *victim_rgn = NULL;
 	struct victim_select_info *lru_info = &hpb->lru_info;
 	unsigned long flags;
 	int ret = 0;
@@ -1256,7 +1264,15 @@ static int ufshpb_add_region(struct ufshpb_lu *hpb, struct ufshpb_region *rgn)
 			 * It is okay to evict the least recently used region,
 			 * because the device could detect this region
 			 * by not issuing HPB_READ
+			 *
+			 * in host control mode, verify that the entering
+			 * region has enough reads
 			 */
+			if (hpb->is_hcm && rgn->reads < EVICTION_THRESHOLD) {
+				ret = -EACCES;
+				goto out;
+			}
+
 			victim_rgn = ufshpb_victim_lru_info(hpb);
 			if (!victim_rgn) {
 				dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
-- 
2.25.1