Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 31 Mar 2021 13:16:58 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Fabio Aiuto <fabioaiuto83@gmail.com>
Cc:     gregkh@linuxfoundation.org, joe@perches.com,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/40] staging: rtl8723bs: replace RT_TRACE with public
 printk wrappers in core/rtw_xmit.c
Message-ID: <20210331101658.GK2065@kadam>
References: <cover.1617183374.git.fabioaiuto83@gmail.com>
 <75c8a2396a0cae9ad7933577b20dfbf3a7ce6816.1617183374.git.fabioaiuto83@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <75c8a2396a0cae9ad7933577b20dfbf3a7ce6816.1617183374.git.fabioaiuto83@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

I'm sorry but we can't accept this patch.

> @@ -481,12 +481,13 @@ static s32 update_attrib_sec_info(struct adapter *padapter, struct pkt_attrib *p
>  	pattrib->mac_id = psta->mac_id;
>  
>  	if (psta->ieee8021x_blocked == true) {
> -		RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("\n psta->ieee8021x_blocked == true\n"));
> +		pr_err("%s psta->ieee8021x_blocked == true\n", DRIVER_PREFIX);

Here we have change debug code that's never printed into an error
message.

A bunch of the rest are technically "wrong" but harmless.

>  	if (!pxmitpriv->pallocated_frame_buf) {
>  		pxmitpriv->pxmit_frame_buf = NULL;
> -		RT_TRACE(_module_rtl871x_xmit_c_, _drv_err_, ("alloc xmit_frame fail!\n"));
> +		pr_err("%s alloc xmit_frame fail!\n", DRIVER_PREFIX);

We don't print warning messages for allocation failures.  Checkpatch
is supposed to complain.

I always encourage people to think about everything deeply and look at
the context and read the error messages.  But if you send a patch which
mindlessly deletes all these RT_TRACE() messages, then we will apply
that.

It's unfortunate that you have to re-write the first patch in a 40
patch series.  :/

regards,
dan carpenter