Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] perf data: export to JSON
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@redhat.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Tan Xiaojun <tanxiaojun@huawei.com>,
        linux-kernel@vger.kernel.org
References: <4687bbe5-4ff3-af3a-fcec-06d8bfe5591c@codeweavers.com>
 <YFs/B0/S7IEKeL/Y@kernel.org>
From:   Nicholas Fraser <nfraser@codeweavers.com>
Message-ID: <8114de32-9874-450e-8d48-8fd4389449fa@codeweavers.com>
Date:   Wed, 31 Mar 2021 06:32:23 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YFs/B0/S7IEKeL/Y@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Arnaldo,

Thanks for the review. I'll send a replacement patch with your suggestions.

On 2021-03-24 9:30 a.m., Arnaldo Carvalho de Melo wrote:
> Do you plan to output the headers too? I think we should, for
> completeness.

I've added the headers, at least the ones that seemed important or easy to
output. The result looks like this:

	"headers": {
			"header-version": 1,
			"captured-on": "2021-03-30T19:24:22Z",
			"data-offset": 304,
			"data-size": 35000,
			"feat-offset": 35304,
			"hostname": "foundry",
			"os-release": "5.11.8-arch1-1",
			"arch": "x86_64",
			"cpu-desc": "Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz",
			"cpuid": "GenuineIntel,6,142,10",
			"nrcpus-online": 8,
			"nrcpus-avail": 8,
			"perf-version": "5.11.gf40ddce88593",
			"cmdline": [
				"/usr/bin/perf",
				"record",
				"vkcube"
			]
	},

(I've thus far avoided outputting anything we don't use; I'm unlikely to design
a useful format for data if I don't have a real use case for it. We will
probably make use of some of the headers though so it's worth doing now.)

Nick