Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp312434pxf; Wed, 31 Mar 2021 04:06:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwrInamplIiynK0i1IpRGtHo/oerI/8coZoLulwc3UElArH//7LeBkC/KWbPtjw1QzebgU X-Received: by 2002:a05:6402:31e9:: with SMTP id dy9mr3059300edb.186.1617188812779; Wed, 31 Mar 2021 04:06:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617188812; cv=none; d=google.com; s=arc-20160816; b=hy0HyxYyQBT69vR3RuXpM7EvZi4o63UxxOrtUAvw9OeUehb4raThEMfdwK2mjZpFNy w94Xsm+8JlIutHSVqlDjnueOr/lXEkaF0Ds7xRWEx5sVKyx+3nJBgdJKcFxm5SH001U3 7QPXEgMdMZDdOEiUDrtFXMwsoeZflhJBj/PkLEOgfFXS2iMJSmc5r0S/nxuX0Riwdum6 rk3xb48ZUQPptkdgj+CTcQQYHIbvPn/gZ6dLih3LwSSSypURdWeDRPeFafP9m6x0i/2z eyoZNN/39pFY/HKYHCO9WHpF0egLFRGbA5hpGQshjHVpTfaXVFX+feg3ngk1oZ+KFWqY RG0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=t6rZK9mZsW6uMrGowYb+WNWM2qXFmDa4s5/W2k9c0cI=; b=dCdo0k2s9U0UAlnP2MdTvTIGzSza2AFzvo6SUOjxp2fQ1LSQHWMesYt+otZBq3uDD/ HdI/+5q3/F0K+zFs2TC6NHedoekDzjA81V6oKw8f4y2pwSruhaeoas7+lrX7LLHy8zed kAK6m67JTmbj5XSomDs4CH1lxR0Rs+AxDmyPVNlUAFsgSo/oZEJbgcSO0VL8MWThGgts PqHNJHlIHuiXEzsVfQomf/sJxg6hVl0q/2X7MbWjLFekl+uGzfYAtagJJh5F+iqBpoqQ 6E3O2pE4qRgQ1Y4eI7dJF64pe90jGVDgFWJAnj8WH7aXUuVma+Fp3bmH0AEDvQBNP3Al DrFg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hc31si1337788ejc.524.2021.03.31.04.06.29; Wed, 31 Mar 2021 04:06:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234377AbhCaLF1 (ORCPT + 99 others); Wed, 31 Mar 2021 07:05:27 -0400 Received: from mga04.intel.com ([192.55.52.120]:62720 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234942AbhCaLFI (ORCPT ); Wed, 31 Mar 2021 07:05:08 -0400 IronPort-SDR: jlqgy3hJapjSca61A3o6vcR7zwzYrtccTFOqW3UmcbqLE6hdaKqRdKpeyvhYYfO0KzBX/VKelV hv+arf9py+dg== X-IronPort-AV: E=McAfee;i="6000,8403,9939"; a="189746724" X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="189746724" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2021 04:05:07 -0700 IronPort-SDR: QRQwEgHBZSFb1xEtQhhWTpkwzOxXH4ut6pbyf+63s9r76kjWrP6haS8JrBMv3kNww/E+CmVupJ K6WzsiOdDNzQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,293,1610438400"; d="scan'208";a="445594502" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 31 Mar 2021 04:05:04 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0AE25133; Wed, 31 Mar 2021 14:05:18 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Serge Semin , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jarkko Nikula , Mika Westerberg , wsa@kernel.org, Yicong Yang , "Song Bao Hua (Barry Song)" Subject: [PATCH v1 1/1] i2c: designware: Adjust bus_freq_hz when refuse high speed mode set Date: Wed, 31 Mar 2021 14:05:10 +0300 Message-Id: <20210331110510.67523-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When hardware doesn't support High Speed Mode, we forget bus_freq_hz timing adjustment. This makes the timings and real registers being unsynchronized. Adjust bus_freq_hz when refuse high speed mode set. Fixes: b6e67145f149 ("i2c: designware: Enable high speed mode") Reported-by: "Song Bao Hua (Barry Song)" Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i2c/busses/i2c-designware-master.c b/drivers/i2c/busses/i2c-designware-master.c index 34bb4e21bcc3..9bfa06e31eec 100644 --- a/drivers/i2c/busses/i2c-designware-master.c +++ b/drivers/i2c/busses/i2c-designware-master.c @@ -129,6 +129,7 @@ static int i2c_dw_set_timings_master(struct dw_i2c_dev *dev) if ((comp_param1 & DW_IC_COMP_PARAM_1_SPEED_MODE_MASK) != DW_IC_COMP_PARAM_1_SPEED_MODE_HIGH) { dev_err(dev->dev, "High Speed not supported!\n"); + t->bus_freq_hz = I2C_MAX_FAST_MODE_FREQ; dev->master_cfg &= ~DW_IC_CON_SPEED_MASK; dev->master_cfg |= DW_IC_CON_SPEED_FAST; dev->hs_hcnt = 0; -- 2.30.2