Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp342393pxf; Wed, 31 Mar 2021 04:57:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJaINeflrmWdMlaZaUNKlXXQgXKrR9i0FB2ChXIW54Lx8AjCHs29KyT9AbCuVNfOZrrYhY X-Received: by 2002:a05:6402:b41:: with SMTP id bx1mr3275960edb.69.1617191875800; Wed, 31 Mar 2021 04:57:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617191875; cv=none; d=google.com; s=arc-20160816; b=uB63BII8zK3aA57McyVk4qSjzX8qBLKyiCrg+yp11vJs+h8s+fV3RsaySKf52EOltL q3ZT6b0j7PckmgpWEGDmG9ejujeE5RiLNA/SlgWjrXcE9Kru50s6ILzzYNBXkg2CNHzH 3i5sKiJKu/22qrzQlo+k+rShw8/OoGDNoaqvmVOHLpd4GSldC0vMvL5CO18Uxngw/skb V17zOJiy8bp7wFociyOiPSL0WomNqRHKTxlsv6dn2oSTYWZbR4vbyob7XlykNLUDG3a8 UXaabZ7soz4Lr0aLDJBxt4v2gnv1VfTmtvItiq0Ry8eVPwzh7LAJflj6egWxcpGQAVY4 BeNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Yd8tOZVz6gRmShY+n7RBaDAftQ7/phAAzuDMRSothXI=; b=V0YcoUooInVjUPjO4lJouW15oCyw/eksg9UpjHMy5f9vRbHLV0ND/juK4HZ2m4k5cZ mqNSAT5s0UzeT4bBz1S856ZK40hpj6EKhMyXLJceq3HS3jsXzrq27OUwjrJO1dyOC2nr pwlIqtX2FxDBrD5X4XO8XS6jGD9wgdYuiJtagnsKip7zzzbkMZAywJqDAw597oFxZUrL m4KZqqp75erksseQY3UiBm/wQ5Npvan3N82V5CwD0t/7GvGZT8NzONurD9duMAFTP71Q oAIuvv+PijWzrz/vIMCBq1tjnOyG8Fhx3+tDHsL/7oP8DvChVpdi9/TlB7evGLLlp6ia 6mHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k12si1581285eds.217.2021.03.31.04.57.32; Wed, 31 Mar 2021 04:57:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235314AbhCaL4g (ORCPT + 99 others); Wed, 31 Mar 2021 07:56:36 -0400 Received: from mx2.suse.de ([195.135.220.15]:51730 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235014AbhCaL4G (ORCPT ); Wed, 31 Mar 2021 07:56:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 167F7B1E0; Wed, 31 Mar 2021 11:56:05 +0000 (UTC) From: Thomas Bogendoerfer To: Steven Rostedt , Ingo Molnar , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Cc: hch@lst.de Subject: [PATCH v2 1/4] MIPS: kernel: Remove not needed set_fs calls Date: Wed, 31 Mar 2021 13:55:58 +0200 Message-Id: <20210331115603.146159-2-tsbogend@alpha.franken.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210331115603.146159-1-tsbogend@alpha.franken.de> References: <20210331115603.146159-1-tsbogend@alpha.franken.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org flush_icache_range always does flush kernel address ranges, so no need to do the set_fs dance. Signed-off-by: Thomas Bogendoerfer --- arch/mips/kernel/ftrace.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c index 666b9969c1bd..8c401e42301c 100644 --- a/arch/mips/kernel/ftrace.c +++ b/arch/mips/kernel/ftrace.c @@ -90,7 +90,6 @@ static int ftrace_modify_code_2(unsigned long ip, unsigned int new_code1, unsigned int new_code2) { int faulted; - mm_segment_t old_fs; safe_store_code(new_code1, ip, faulted); if (unlikely(faulted)) @@ -102,10 +101,7 @@ static int ftrace_modify_code_2(unsigned long ip, unsigned int new_code1, return -EFAULT; ip -= 4; - old_fs = get_fs(); - set_fs(KERNEL_DS); flush_icache_range(ip, ip + 8); - set_fs(old_fs); return 0; } @@ -114,7 +110,6 @@ static int ftrace_modify_code_2r(unsigned long ip, unsigned int new_code1, unsigned int new_code2) { int faulted; - mm_segment_t old_fs; ip += 4; safe_store_code(new_code2, ip, faulted); @@ -126,10 +121,7 @@ static int ftrace_modify_code_2r(unsigned long ip, unsigned int new_code1, if (unlikely(faulted)) return -EFAULT; - old_fs = get_fs(); - set_fs(KERNEL_DS); flush_icache_range(ip, ip + 8); - set_fs(old_fs); return 0; } -- 2.29.2