Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp380441pxf; Wed, 31 Mar 2021 05:55:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyjTQEsBPY1uC5uvsVnxvVDA3EVkMt4oDBb2am2EedHRKT/XfCFFI52vSYXzUKACTXJ3+0 X-Received: by 2002:a17:906:dd6:: with SMTP id p22mr3442389eji.111.1617195340192; Wed, 31 Mar 2021 05:55:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1617195340; cv=none; d=google.com; s=arc-20160816; b=VYt74sPUDfG4gnYZlhC+iaTGTSbg/APJagUYW/eBjhqSy9o+oDhQkX8OJthcc1xMAB sjybB09ndkSX8BsDU5BlUIx4sCm3VcRwxtpgqfnFkTkh7OisertxBdqIkLIYpq/gM1fr GkjTovRpl0rKWT5t+vXLUWGCTvcIluvNGdH5go6eGyfoLwYmCTeHz7k26sSyOH7+4mvI NDHPDc3KGDNEy2sKc1jWFv7419Z0lz9LvE58KelgAs1ZqLjTKrY+Byo7UCLEfr3XLQH4 EJ2LpHue7tzx8KggCw0PJFlnx8zgxYD5rr88s/wEj7jiIr4F/V4tdr52gUHBduKufdPf nJ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:references :mail-followup-to:message-id:subject:cc:to:from:date; bh=0ipQU6ls0IqHWqXLzw3dszfp6FUVLtsO352zBYz7gs4=; b=bsIhCs/RXxPdH3WDA3eiKuHzNuRNfz9CtLFjH7MVObe+855i+0sZQTXwQ0k+30tyNh zPijtDWdwo4fysoIMV2ZWe6mJ46dgo7TrCrScZoEAuE7oyIEMyouZKOhNgON0MZcwqDU p3n4CFr1b3t1ZBoSeuH3aFzUTa1yqlJf6PQPCMIKnYIpyXH0VKo0tvTFr8YV2qkyl73p ieiXwrXGr6mJpB+e7s2EjVTXmWsVROURbTFRRYSMj8E9iMV8h3dGWX0/RAZ2ZMubrVZV +85N/TjfD4FkEt5/fSAZpv+1w022JXNsz5FIRu8Lu3BjgSWBK/TjCG7Z99z9r4fkzaeN WvCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cx5si1695994edb.555.2021.03.31.05.55.17; Wed, 31 Mar 2021 05:55:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235683AbhCaMyS (ORCPT + 99 others); Wed, 31 Mar 2021 08:54:18 -0400 Received: from mail.thorsis.com ([92.198.35.195]:59344 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235654AbhCaMyB (ORCPT ); Wed, 31 Mar 2021 08:54:01 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.thorsis.com (Postfix) with ESMTP id 885F93970; Wed, 31 Mar 2021 14:53:59 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.thorsis.com Received: from mail.thorsis.com ([127.0.0.1]) by localhost (mail.thorsis.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ddy8e7D0VyZZ; Wed, 31 Mar 2021 14:53:59 +0200 (CEST) Received: by mail.thorsis.com (Postfix, from userid 109) id 53D3D390B; Wed, 31 Mar 2021 14:53:59 +0200 (CEST) X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was * blocked. See * http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block * for more information. * [URIs: thorsis.com] * -0.0 NO_RELAYS Informational: message was not relayed via SMTP * -0.0 NO_RECEIVED Informational: message has no Received headers Date: Wed, 31 Mar 2021 14:53:48 +0200 From: Alexander Dahl To: Andy Shevchenko Cc: Alexander Dahl , Linux Documentation List , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet Subject: Re: [PATCH 1/3] docs: gpio: mockup: Fix parameter name Message-ID: Mail-Followup-To: Andy Shevchenko , Linux Documentation List , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linus Walleij , Bartosz Golaszewski , Jonathan Corbet References: <20210329111648.7969-1-ada@thorsis.com> <20210329111648.7969-2-ada@thorsis.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Andy, Am Wed, Mar 31, 2021 at 03:27:05PM +0300 schrieb Andy Shevchenko: > On Mon, Mar 29, 2021 at 2:18 PM Alexander Dahl wrote: > > > > Module probing with the parameter documented yielded this in kernel log: > > > > gpio_mockup: unknown parameter 'gpio_named_lines' ignored > > > > The parameter documented did not match the parameter actually > > implemented with commit 8a68ea00a62e ("gpio: mockup: implement naming > > the lines") long before introducing the documentation. > > > > Fixes: commit 2fd1abe99e5f ("Documentation: gpio: add documentation for gpio-mockup") > > Alexander, in the entire series you are using the wrong format for the > Fixes tag. > I highly recommend to add in your .gitconfig file an alias: > one = show -s --pretty='format:%h (\"%s\")' You're right. Sorry, I messed things up. I first had that line without the additional "commit", and added it because I thought checkpatch complained (which it probably did not). The actual format is documented of course: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes I actually have a slightly different setting for pretty.fixes in my ~/.gitconfig for other demands. I'll go and make that project dependent now. Thanks for pointing this out. Greets Alex > > `git one ` will give you proper value to refer to the > commit in question. > > -- > With Best Regards, > Andy Shevchenko