Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: rY+QJgqxCUX6FcEsaGRp3TSR4Fis/Le1Mzj4KY3jw3RRwrej3of7deDVsUz9xFR1UgVw43OOhO
 GHd6nXFQYgwA5P4XS91I0rI3SkRYlJL5nYTMfoiZ/miWIKoJaAYvWOQ2mbQnfk3LndKsb6dK6+
 ocCXiHAu05U4yDAAbyMPW65ti6DB6Ep5XGyoCUzgqtpnwOcVoanQc1jeNEM65yPvb5tRTni2Uj
 M+64mKs+Lwxaeug2WPFW4MWHUcVYhjlrvbexRSvlBjbf8bK/SRPvWQjPA3LTTyXSojpRquwk2e
 /JA=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Can Guo <cang@codeaurora.org>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "nguyenb@codeaurora.org" <nguyenb@codeaurora.org>,
        "hongwus@codeaurora.org" <hongwus@codeaurora.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     Alim Akhtar <alim.akhtar@samsung.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Stanley Chu <stanley.chu@mediatek.com>,
        Bean Huo <beanhuo@micron.com>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v4 1/2] scsi: ufs: Fix task management request completion
 timeout
Thread-Topic: [PATCH v4 1/2] scsi: ufs: Fix task management request completion
 timeout
Thread-Index: AQHXJeluDHVEm07RiUyOVABPGwr9daqeTcVw
Date:   Wed, 31 Mar 2021 16:45:04 +0000
Message-ID: <BL0PR04MB656448E22577076A27F1EADAFC7C9@BL0PR04MB6564.namprd04.prod.outlook.com>
References: <1617166236-39908-1-git-send-email-cang@codeaurora.org>
 <1617166236-39908-2-git-send-email-cang@codeaurora.org>
In-Reply-To: <1617166236-39908-2-git-send-email-cang@codeaurora.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1f1d8bd0-c73d-47a8-2c42-08d8f4645596
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2021 16:45:04.2378
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: y4CGV0B5/9iaDYQsRMI/8SjMuLbB0ENKzN+L3Y6mmz5uMTo/dVYCk9ejkM6ebu5Q4cJDLQrdPd0mBO5AsesmxQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR04MB6333
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn =3D
> ufshcd_compl_tm()),
> but since blk_mq_tagset_busy_iter() only iterates over all reserved tags
> and requests which are not in IDLE state, ufshcd_compl_tm() never gets a
> chance to run. Thus, TMR always ends up with completion timeout. Fix it b=
y
> calling blk_mq_start_request() in  __ufshcd_issue_tm_cmd().
>=20
> Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to allocate =
and
> free TMFs")
>=20
> Signed-off-by: Can Guo <cang@codeaurora.org>
> ---
>  drivers/scsi/ufs/ufshcd.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index b49555fa..d4f8cb2 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6464,6 +6464,7 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba
> *hba,
>=20
>         spin_lock_irqsave(host->host_lock, flags);
>         task_tag =3D hba->nutrs + free_slot;
> +       blk_mq_start_request(req);
Maybe just set req->state to MQ_RQ_IN_FLIGHT
Without all other irrelevant initializations such as add timeout etc.

Thanks,
Avri
>=20
>         treq->req_header.dword_0 |=3D cpu_to_be32(task_tag);
>=20
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a
> Linux Foundation Collaborative Project.